User tests: Successful: Unsuccessful:
Set the correct index name
@richard67 if accepted would we need to do an update sql as well?
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Installation Postgresql |
If the same index had been created in an old 4.x update SQL it would even need to change that, too, but that's not the case here, I think.
Should I do that here or in a separate pr ?
Better here. If necessary I will suggest changes then.
Labels |
Added:
?
|
Category | SQL Installation Postgresql | ⇒ | SQL Administration com_admin Postgresql Installation |
Update SQL scripts look good to me.
I have tested this item
Testing instructions for other testers: Update a clean, current 4.1 (latest nightly or current 4.1-dev) to the custom update URL or the update package created by drone for this PR. After the update, check that the index has the right name and that the database checker shown only the usual error about the update version not matching the CMS version, which is normal for the patched packages built buy drone, but no other error.
@brianteeman Could you provide some testing instructions? You can find inspiration in my previous comment with my test result. Thanks in advance.
P.S. I've tested with both MySQL and PostgreSQL.
I have tested this item
My previous test is still valid since the change after that was just SQL code style.
I have tested this item
Tested on MySQL
I have tested this item
Tested on MySQL
Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-31 15:54:46 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Thx
thanks
@brianteeman Yes. And it needs 2 separate statements, one to drop with index with tie old name and another one to create the index with the new name, because the database checker can't handle index renaming yet.