? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jan 2022

Set the correct index name

@richard67 if accepted would we need to do an update sql as well?

avatar brianteeman brianteeman - open - 24 Jan 2022
avatar brianteeman brianteeman - change - 24 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2022
Category SQL Installation Postgresql
avatar richard67
richard67 - comment - 24 Jan 2022

@brianteeman Yes. And it needs 2 separate statements, one to drop with index with tie old name and another one to create the index with the new name, because the database checker can't handle index renaming yet.

avatar richard67
richard67 - comment - 24 Jan 2022

If the same index had been created in an old 4.x update SQL it would even need to change that, too, but that's not the case here, I think.

avatar brianteeman
brianteeman - comment - 24 Jan 2022

Should I do that here or in a separate pr ?

avatar richard67
richard67 - comment - 24 Jan 2022

Better here. If necessary I will suggest changes then.

avatar brianteeman brianteeman - change - 24 Jan 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2022
Category SQL Installation Postgresql SQL Administration com_admin Postgresql Installation
avatar richard67
richard67 - comment - 24 Jan 2022

Update SQL scripts look good to me.

avatar richard67
richard67 - comment - 24 Jan 2022

I have tested this item successfully on 38488bf

Testing instructions for other testers: Update a clean, current 4.1 (latest nightly or current 4.1-dev) to the custom update URL or the update package created by drone for this PR. After the update, check that the index has the right name and that the database checker shown only the usual error about the update version not matching the CMS version, which is normal for the patched packages built buy drone, but no other error.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar richard67 richard67 - test_item - 24 Jan 2022 - Tested successfully
avatar richard67
richard67 - comment - 24 Jan 2022

@brianteeman Could you provide some testing instructions? You can find inspiration in my previous comment with my test result. Thanks in advance.

avatar richard67
richard67 - comment - 24 Jan 2022

P.S. I've tested with both MySQL and PostgreSQL.

avatar richard67
richard67 - comment - 24 Jan 2022

I have tested this item successfully on 86fc641

My previous test is still valid since the change after that was just SQL code style.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar richard67 richard67 - test_item - 24 Jan 2022 - Tested successfully
avatar Quy Quy - test_item - 25 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 25 Jan 2022

I have tested this item successfully on 86fc641

Tested on MySQL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar Quy
Quy - comment - 25 Jan 2022

I have tested this item successfully on 86fc641

Tested on MySQL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar Quy Quy - change - 25 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar Quy
Quy - comment - 25 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36817.

avatar bembelimen bembelimen - close - 31 Jan 2022
avatar bembelimen bembelimen - merge - 31 Jan 2022
avatar bembelimen bembelimen - change - 31 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-31 15:54:46
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 31 Jan 2022

Thx

avatar brianteeman
brianteeman - comment - 31 Jan 2022

thanks

Add a Comment

Login with GitHub to post a comment