? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
31 May 2014

According to our new development strategy:
http://developer.joomla.org/news/586-joomla-development-strategy.html#version_numbering

We don't use LTS or STS anymore.

avatar zero-24 zero-24 - open - 31 May 2014
avatar sovainfo
sovainfo - comment - 31 May 2014

Suggest to use a space before :
That would make it more consistent with the rest of the code: ") : ?>", one blank before and after :

Also consistently calling methods, currently there is mixed use of :: and ->
Suggest to use :: only after a classname, -> with objects.

avatar zero-24
zero-24 - comment - 31 May 2014

@sovainfo are you sure that you mean this PR?

I only change language strings ;)

avatar sovainfo
sovainfo - comment - 31 May 2014

Yep, see 5d5dec1

avatar zero-24
zero-24 - comment - 31 May 2014

hmm I don't know what you mean. I have send a pull against 3.4-dev.

please see here: https://github.com/joomla/joomla-cms/pull/3681/files for the changes (at the 3.4-dev branche)

avatar zero-24
zero-24 - comment - 31 May 2014

@sovainfo it is a CS issue at staging see: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/views/help/tmpl/default.php#L36

please open a new itm for this. I don't touch this file with my patch

avatar zero-24
zero-24 - comment - 31 May 2014

again @sovainfo please send this as a seperat github PR against staging.
Thanks

avatar nicksavov
nicksavov - comment - 31 May 2014

Hi Tobias,

Check out 6.1.6 of the new development strategy. The language string keys cannot be deleted or changed.

My suggestion is to add a new string and leave the old ones there, also adding a note to deprecate them for removal in 4.0.

Also, you'll need to update the place that uses those strings and change it to the new strings.

Finally, what are currently the LTS and STS tracks will also update a site from minor to minor. So for example, if you're on Joomla 3.3 and have either setting on, you can update to 3.4 when it's released. However, STS will also update you to 4.0 if it's released, whereas LTS won't. So using "Next Major Release" will be confusing in some scenarios, since it's also used for updating to next minor. At this time, I'm not sure of a better way to say it though.

avatar b2z
b2z - comment - 2 Jun 2014

However, STS will also update you to 4.0 if it's releases, whereas LTS won't. So using "Next Major Release" will be confusing in some scenarios, since it's also used for updating to next minor.

Yeah, that's funny. But we definitely need to solve it and to rid out of STS/LTS. May be it is possible to change the strategy on update server side?

avatar Bakual
Bakual - comment - 2 Jun 2014

May be it is possible to change the strategy on update server side?

That may be possible I think, but I'm not sure if we want.
I think the current behavior is actually what we want. One option will stay within the current major version (currently "LTS") and the other one will always update to the latest available version (currently "STS").

We just need to come up with some clever names for those options

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar b2z
b2z - comment - 17 Sep 2014

Is it still valid? ;)

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar zero-24
zero-24 - comment - 17 Sep 2014

@b2z Yes it is still valid but we have no accepted Idea how to handel this.

avatar nicksavov
nicksavov - comment - 17 Sep 2014

I think your text changes are as good as we can get it right now. Let's go with those, since they are big improvements over what we currently have.

Could you update the PR to leave the old strings there? Also, mark them as deprecated for 4.0.

And you'll need to update the place that uses those strings and change it to the new strings.

Thanks Tobias!

avatar zero-24
zero-24 - comment - 19 Sep 2014

@nicksavov please have a look now.

I'm not sure if we can change the values for the update server. For now i have add a inline comment to do this with 4.0 but it could be possible to do this with the next release and leave the "old" values as seccond case to
https://github.com/zero-24/joomla-cms/blob/new_update_strings/administrator/components/com_joomlaupdate/models/default.php#L41
and
https://github.com/zero-24/joomla-cms/blob/new_update_strings/administrator/components/com_joomlaupdate/models/default.php#L46

What do you think about it?

avatar brianteeman
brianteeman - comment - 19 Sep 2014

It is not correct english to say that you will upgrade to the Next release you can only upgrade to the current or new release

avatar zero-24
zero-24 - comment - 19 Sep 2014

done (Next --> New) thanks @brianteeman

avatar zero-24
zero-24 - comment - 19 Sep 2014

@nicksavov is fixed now:

"Latest" instead of "Next"?

I have change to New (as we use on the language string)

Please have also a look into the new @deprecated tag: zero-24@1b7fee9

avatar nicksavov
nicksavov - comment - 19 Sep 2014

Thanks again, Tobias!

Sorry, I meant "Latest" instead of "New". I think "Latest" would work better than both the previous versions.

"Latest Major Release"
"Latest Minor & Patch Release (recommended)"

avatar zero-24
zero-24 - comment - 19 Sep 2014

done @nicksavov

avatar nicksavov
nicksavov - comment - 19 Sep 2014

Looks good to me. Nice job, Tobias! :)

Anyone else see anything that needs improving?

avatar brianteeman
brianteeman - comment - 19 Sep 2014

I still prefer current to new. New has specific implications that may not be correct 3 months after a release. But current always means the same thing

avatar nicksavov
nicksavov - comment - 19 Sep 2014

Agreed, "Current" > "New".

What about "Current" vs "Latest"? Which would sound better in this context? I'll lean toward whatever you think is best, since en-GB is your specialty :)

avatar brianteeman
brianteeman - comment - 19 Sep 2014

Current

On 19 September 2014 21:44, Nick Savov notifications@github.com wrote:

Agreed, "Current" > "New".

What about "Current" vs "Latest"? Which would sound better in this
context? I'll lean toward whatever you think is best, since en-GB is your
specialty :)


Reply to this email directly or view it on GitHub
#3681 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 19 Sep 2014

ok i will update to Current thanks @brianteeman and @nicksavov

avatar zero-24
zero-24 - comment - 19 Sep 2014
avatar nicksavov
nicksavov - comment - 19 Sep 2014

Cheers guys

avatar zero-24
zero-24 - comment - 19 Sep 2014

So we can move this now to RTC or need this more discussion e.g. by PLT etc?

avatar nicksavov
nicksavov - comment - 19 Sep 2014

I think it's good enough for RTC and we've have enough eyes on it. The PR (granted, not in its final state) has been around since the end of May, so that's plenty of time for someone to have taken a look if there were concerns.

The committer can bring it down to Pending if there are any issues.

Moving to RTC.

p.s. I'll message PLT about setting up a standard for deprecating language strings.

avatar nicksavov nicksavov - change - 19 Sep 2014
Category Updating
avatar nicksavov nicksavov - change - 19 Sep 2014
Status Pending Ready to Commit
Easy No Yes
avatar zero-24 zero-24 - change - 19 Sep 2014
Category Updating Administration Language & Strings Updating
avatar mbabker mbabker - change - 22 Sep 2014
Milestone Added:
avatar mbabker mbabker - change - 22 Sep 2014
Milestone Added:
avatar phproberto phproberto - change - 8 Oct 2014
Labels Added: ?
avatar phproberto phproberto - reference | 6dd33ee - 8 Oct 14
avatar phproberto phproberto - close - 8 Oct 2014
avatar phproberto
phproberto - comment - 8 Oct 2014

Merged into 3.4-dev 6dd33ee

Thanks!

avatar phproberto phproberto - close - 8 Oct 2014
avatar phproberto phproberto - change - 8 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-08 08:56:44
avatar zero-24 zero-24 - head_ref_deleted - 31 May 2015

Add a Comment

Login with GitHub to post a comment