? ? ? Pending

User tests: Successful: Unsuccessful:

avatar beat
beat
22 Jan 2022

Pull Request for Issue # none

Summary of Changes

Fixes Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101 and a few more (line 35, line 53, line 115)
and same in Protostar and Beez modules.php

Testing Instructions

Code review.

Or see front-end with PHP 8.1, debug ON, and all PHP errors on.

Actual result BEFORE applying this Pull Request

Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101
and in some other cases:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 35
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 53
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 115

Expected result AFTER applying this Pull Request

not those warnings anymore.

Documentation Changes Required

None.

avatar beat beat - open - 22 Jan 2022
avatar beat beat - change - 22 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2022
Category Front End Templates (site)
avatar beat beat - change - 22 Jan 2022
Title
[3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible
WIP: [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible
avatar beat beat - edited - 22 Jan 2022
avatar beat
beat - comment - 22 Jan 2022

Making WIP, protostar has same issue, maybe beez too,more commits coming.

avatar beat beat - change - 22 Jan 2022
Labels Added: ?
avatar beat beat - change - 22 Jan 2022
Title
WIP: [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible
[3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible
avatar beat beat - edited - 22 Jan 2022
avatar beat beat - change - 22 Jan 2022
The description was changed
avatar beat beat - edited - 22 Jan 2022
avatar beat
beat - comment - 22 Jan 2022

Removed WIP, ready for review.

avatar alikon
alikon - comment - 23 Jan 2022

I have tested this item successfully on fcd5647


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794.

avatar alikon alikon - test_item - 23 Jan 2022 - Tested successfully
avatar richard67
richard67 - comment - 23 Jan 2022

I have tested this item successfully on fcd5647

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794.

avatar richard67 richard67 - test_item - 23 Jan 2022 - Tested successfully
avatar richard67 richard67 - edited - 23 Jan 2022
avatar richard67 richard67 - change - 23 Jan 2022
The description was changed
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36794.

avatar zero-24
zero-24 - comment - 23 Jan 2022

Merging thanks :)

avatar zero-24 zero-24 - change - 23 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-23 14:18:09
Closed_By zero-24
Labels Added: ? ?
avatar zero-24 zero-24 - close - 23 Jan 2022
avatar zero-24 zero-24 - merge - 23 Jan 2022

Add a Comment

Login with GitHub to post a comment