RTC PR-3.10-dev

Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 Jan 2022

Pull Request for Issue #36788 and #35895 .

Summary of Changes

Correctly check path

Testing Instructions

Follow #36788 and #35895

Actual result BEFORE applying this Pull Request

A warning about open_basedir stuff

Expected result AFTER applying this Pull Request

No warning

Documentation Changes Required

None

avatar Fedik Fedik - open - 22 Jan 2022
avatar Fedik Fedik - change - 22 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2022
Category Administration com_menus
avatar ChristineWk
ChristineWk - comment - 22 Jan 2022

I have tested this item successfully on 729f382

J 3.10.5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

avatar ChristineWk ChristineWk - test_item - 22 Jan 2022 - Tested successfully
avatar richard67
richard67 - comment - 23 Jan 2022

I have tested this item successfully on 729f382

Tested on a copy of my homepage on my domain, where I have and always had open_basedir restrictions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

avatar richard67 richard67 - test_item - 23 Jan 2022 - Tested successfully
avatar richard67 richard67 - change - 23 Jan 2022
Labels Added: PR-3.10-dev
avatar richard67
richard67 - comment - 23 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

avatar richard67 richard67 - change - 23 Jan 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

avatar zero-24
zero-24 - comment - 23 Jan 2022

Hmm that method is setup far from ideal as it depends on cases and not in all cases the variables are setup correctly. For example this issue here comes only up when the "option" == component can not be found. When that has been found it will fallback to the component root. But this patch here is right as we can not try to fallback to the component root when we do not have any information about it :)

Thanks

avatar zero-24 zero-24 - change - 23 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-23 14:13:38
Closed_By zero-24
Labels Added: RTC
avatar zero-24 zero-24 - close - 23 Jan 2022
avatar zero-24 zero-24 - merge - 23 Jan 2022
avatar silverislander silverislander - test_item - 24 Jan 2022 - Tested successfully
avatar silverislander
silverislander - comment - 24 Jan 2022

I have tested this item successfully on 729f382

Tested successfully on a client website (managed hosting).

J 3.10.5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

avatar TLWebdesign TLWebdesign - test_item - 25 Jan 2022 - Tested successfully
avatar TLWebdesign
TLWebdesign - comment - 25 Jan 2022

I have tested this item successfully on 729f382

Tested this PR on 3.10 and can confirm this fixed the warning.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.

Add a Comment

Login with GitHub to post a comment