[#36789] - [3.10] Fix open_basedir warning when creating a menu item
- Fixed in Code Base
- 23 Jan 2022
- Medium
- Build: 3.10-dev
- # 36789
- Diff
- Fedik:fix-menu-error310
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
Tested on a copy of my homepage on my domain, where I have and always had open_basedir restrictions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.
Hmm that method is setup far from ideal as it depends on cases and not in all cases the variables are setup correctly. For example this issue here comes only up when the "option" == component can not be found. When that has been found it will fallback to the component root. But this patch here is right as we can not try to fallback to the component root when we do not have any information about it :)
Thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-23 14:13:38 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
I have tested this item
Tested successfully on a client website (managed hosting).
J 3.10.5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.
I have tested this item
Tested this PR on 3.10 and can confirm this fixed the warning.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.
I have tested this item✅ successfully on 729f382
J 3.10.5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36789.