[#36786] - [4.1] Fix usage of unset parent ID mapping when getting recursive access rules
- Fixed in Code Base
- 11 Mar 2022
- Medium
- Build: 4.0-dev
- # 36786
- Diff
- richard67:4.0-dev-fix-php-notice-access-rules
User tests: Successful: Unsuccessful:
Pull Request for Issue #36783 .
Summary of Changes
Fix PHP notices Trying to get property 'rules' of non-object in /libraries/src/Access/Access.php on line 548 and Undefined offset: 33 in /libraries/src/Access/Access.php on line 553 caused by access to unset array element when recursive access rules are fetched.
Testing Instructions
Not sure yet how to reproduce the issue. It might need a broken assets table.
The author of the issue was not really able to provide the necessary details on how it can be reproduced.
But maybe a code review would be sufficient.
Actual result BEFORE applying this Pull Request
See issue #36783 .
Expected result AFTER applying this Pull Request
None of these PHP notices mentioned in issue #36783 .
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
Code review looks good, could not reproduce the described behaviour.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36786.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36786.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36786.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-11 14:00:45 |
| Closed_By | ⇒ | laoneo |
Thanks!
I think the problem was caused by changing something in the database via phpmyadmin, such breaking the asset table. But could not reproduce the effect.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36786.