[#36784] - [4.0] Fix RTL for Sample Data Module
- Fixed in Code Base
- 22 Jan 2022
- Medium
- Build: 4.0-dev
- # 36784
- Diff
- pritam825:issue_35850
User tests: Successful: Unsuccessful:
Pull Request for Issue #35850 (partly).
Testing Instructions
first choose the arabic language then
go to home dashboard -> Sample Data
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
Could you change the title of this PR to the name of the module please
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.
| Title |
|
||||||
@pritam825 I've allowed myself to adjust the title of your pull request as recommended by @brianteeman in his comment above.
Please always chose meaningful and understandable titles for pull requests. Thanks in advance.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.
@brianteeman sir, @richard67 sir updated the title.
@richard67 sir, Thanks for updating, Sorry sir for the wrong title, actually I was confused with the title, now understood, Thanks a lot for helping me @brianteeman sir and @richard67 sir.
| Labels |
Added:
?
|
||
@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks
I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).
I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).
@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)
@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks
@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)
It does not need me to tell that 2 times.
And I am able to decide myself which PRs I am looking on.
Ok sir, Thanks :)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-22 20:42:48 |
| Closed_By | ⇒ | bembelimen |
Thx
Thanks for merging
I have tested this item✅ successfully on 646ba4c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.