? ? Pending

User tests: Successful: Unsuccessful:

avatar pritam825
pritam825
22 Jan 2022

Pull Request for Issue #35850 (partly).

Testing Instructions

first choose the arabic language then
go to home dashboard -> Sample Data

Actual result BEFORE applying this Pull Request

Screenshot (1919)

Expected result AFTER applying this Pull Request

Screenshot (1920)

avatar pritam825 pritam825 - open - 22 Jan 2022
avatar pritam825 pritam825 - change - 22 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2022
Category Modules Administration
avatar pritam825 pritam825 - change - 22 Jan 2022
The description was changed
avatar pritam825 pritam825 - edited - 22 Jan 2022
avatar richard67 richard67 - change - 22 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 22 Jan 2022
avatar brianteeman
brianteeman - comment - 22 Jan 2022

I have tested this item successfully on 646ba4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

avatar brianteeman brianteeman - test_item - 22 Jan 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Jan 2022

Could you change the title of this PR to the name of the module please


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 22 Jan 2022

I have tested this item successfully on 646ba4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 22 Jan 2022 - Tested successfully
avatar richard67 richard67 - change - 22 Jan 2022
Title
bootstrap utilities
[4.0] Fix RTL for Sample Data Module
avatar richard67 richard67 - edited - 22 Jan 2022
avatar richard67
richard67 - comment - 22 Jan 2022

@pritam825 I've allowed myself to adjust the title of your pull request as recommended by @brianteeman in his comment above.

Please always chose meaningful and understandable titles for pull requests. Thanks in advance.

avatar richard67 richard67 - change - 22 Jan 2022
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 22 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36784.

avatar pritam825
pritam825 - comment - 22 Jan 2022

@brianteeman sir, @richard67 sir updated the title.
@richard67 sir, Thanks for updating, Sorry sir for the wrong title, actually I was confused with the title, now understood, Thanks a lot for helping me @brianteeman sir and @richard67 sir.

avatar pritam825 pritam825 - change - 22 Jan 2022
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 22 Jan 2022 - brianteeman: Tested successfully
avatar richard67 richard67 - alter_testresult - 22 Jan 2022 - Shubhamverma2796: Tested successfully
avatar pritam825
pritam825 - comment - 22 Jan 2022

@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks

avatar richard67
richard67 - comment - 22 Jan 2022

I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).

avatar pritam825
pritam825 - comment - 22 Jan 2022

I've restored the previous human test results since the changes after that were just removal of a redundant space. So still RTC (ready to commit).

@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)

avatar richard67
richard67 - comment - 22 Jan 2022

@richard67 , can you please have a look on this #36767 PR also, it would be great help, Thanks

@richard67 thanks, I have opened an another PR also, which haven't confirmed yet that, it's right or wrong, can you please please confirm this PR #36767 also, Thanks in advance :)

It does not need me to tell that 2 times.

And I am able to decide myself which PRs I am looking on.

avatar pritam825
pritam825 - comment - 22 Jan 2022

Ok sir, Thanks :)

avatar bembelimen bembelimen - close - 22 Jan 2022
avatar bembelimen bembelimen - merge - 22 Jan 2022
avatar bembelimen bembelimen - change - 22 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-22 20:42:48
Closed_By bembelimen
avatar bembelimen
bembelimen - comment - 22 Jan 2022

Thx

avatar pritam825
pritam825 - comment - 22 Jan 2022

Thanks for merging

Add a Comment

Login with GitHub to post a comment