Feeling Lucky
?
?
?
[#36773] - [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string
- Fixed in Code Base
- 23 Jan 2022
- Medium
- Build: 3.10-dev
- # 36773
- Diff
- beat:patch-12
User tests: Successful: Unsuccessful:
Fixes Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383
Pull Request for Issue # none
Summary of Changes
Sometimes item is null, but in PHP 8.1, trim accepts only string type, not null.
Testing Instructions
Code-review could perfectly be enough as it's obvious.
Look at admin area of 3.10, and see error.
Actual result BEFORE applying this Pull Request
Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383
Expected result AFTER applying this Pull Request
That warning disappears.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
richard67
- comment
- 22 Jan 2022
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36773.
Fedik
- comment
- 22 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36773.
| Status | Pending | ⇒ | Ready to Commit |
Fedik
- comment
- 22 Jan 2022
R2C
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36773.
| Labels |
Added:
?
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-23 18:31:49 |
| Closed_By | ⇒ | zero-24 |
Drone failure here is due to a server issue (database connection), independent of this PR.