[#36759] - [4.3] Finder: Enforce Taxonomies to contain a title
- Fixed in Code Base
- 21 Oct 2022
- Medium
- Build: 4.1-dev
- # 36759
- Diff
- Hackwar:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #35977.
Summary of Changes
If a finder plugin tries to add an empty taxonomy, this can fail with the error message from #35977. This PR should fix that. This most likely is an article with a non-existing author or something similar.
Testing Instructions
Unfortunately I can't replicate the issue from #35977 and the below testing instructions seem to not be able to replicate the problem. Maybe @Stuartemk can investigate this further and try to test this?
- Create a user.
- Create an article and set the author of the article to the previously created user.
- Delete the user.
- Clear your search index and rebuild it.
Actual result BEFORE applying this Pull Request
It fails with the above error message (An Error Has Occurred Category must have a title.)
Expected result AFTER applying this Pull Request
Everything is properly indexed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
| Title |
|
||||||
This pull requests has been automatically converted to the PSR-12 coding standard.
HLeithner
- | Labels |
Added:
?
?
Removed: ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.
I was not able to reproduce the issue. We need better guidance to reproduce the issue...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
|
||
From code review it looks like a valid fix.
The error comes from table class
joomla-cms/administrator/components/com_finder/src/Table/MapTable.php
Lines 63 to 65 in f520c98
The taxonomy title requirement was introduced in #21327
I suspect User may have some custom finder plugin, that not adapted it.
I have tested this item
On review looks valid, everything still works, I count it as success :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.
I have tested this item
Even when I could not reproduce the issue, it also doesn't break things. I tested all the search options and everything seems to be okay. That's a good test IMHO.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36759.
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 16:30:43 |
| Closed_By | ⇒ | laoneo |
Thanks!
Followed test instructions and was unable to replicate the reported problem