[#36754] - Included the title attribute to the image area and image name in media manager.
- Fixed in Code Base
- 21 Jan 2022
- Medium
- Build: 4.0-dev
- # 36754
- Diff
- Shubhamverma2796:issue_36302
User tests: Successful: Unsuccessful:
Pull Request for Issue #36302
Summary of Changes
Included the "title" attribute to the image area and image name in the media manager.
Testing Instructions:
- Home dashboard--> Media manager.
- Hover over any image and notice that the file name is not displayed on hovering over the image before applying this pull request.
- Apply the patch and confirm that the full file name is displayed on hovering over the image in the media manager.
Actual result BEFORE applying this Pull Request
see #36302
Expected result AFTER applying this Pull Request
see #36302
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36754.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36754.
I set RTC because of the 2 good tests, but depending on our release plans (if there will be a 4.0.7 or not) it might be that we have to move this to the 4.1-dev branch.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36754.
I set RTC because of the 2 good tests, but depending on our release plans (if there will be a 4.0.7 or not) it might be that we have to move this to the 4.1-dev branch.
so do i need to create a pr for 4.1 ?
I set RTC because of the 2 good tests, but depending on our release plans (if there will be a 4.0.7 or not) it might be that we have to move this to the 4.1-dev branch.
so do i need to create a pr for 4.1 ?
@Shubhamverma2796 No, all fine. We will rebase the PR if necessary, and worst case is it will need again 2 tests. So you don't need to do anything.
And thank you very much for this PR.
@richard67 Can I delete this branch?
@richard67 Can I delete this branch?
@Shubhamverma2796 No, that would not be good. This pull request here is valid and tested and ready to commit. you can delete the branch after the PR has been merged.
You could also delete it now, it would not break anything, but it would not be good in case if it needs to change something, e.g. if we need to rebase it.
So better not delete it, then we do not have trouble.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-21 12:52:52 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on 652fd45
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36754.