Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
20 Jan 2022

Summary of Changes

A regular request was to be able to also find compoung words. Smart Search right now matches the words exactly, even though it uses a stemmer to find common roots for a word. However those stemmers can only work on single words and "fail" on compound words, like they are very common in for example the german language. This PR allows to switch the matching method between exact matches, matching words starting with the given term and matching words which just contain the term in a random position. I was hoping that there would be a way to automatically split compound words in their different parts and to also index those, however I couldn't find a solution which could be used with justifiable effort. So this is the next best solution as it seems.

Testing Instructions

  1. Apply this PR to your Joomla installation.
  2. Go to the configuration of Smart Search and set the "Word Match" to your prefered setting.
  3. Test searching in the frontend with parts of compound words. No reindexing needed.

Notes

  1. Since 4.1 is in RC, this will have to go into 4.2. Since there is no 4.2-dev branch yet, I'm pointing this towards 4.1-dev for now.
avatar Hackwar Hackwar - open - 20 Jan 2022
avatar Hackwar Hackwar - change - 20 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2022
Category Administration com_finder Language & Strings Front End
avatar Hackwar Hackwar - change - 20 Jan 2022
Labels Added: Language Change ?
avatar HLeithner
HLeithner - comment - 20 Jan 2022

please don't introduce magic numbers, define "words" in the xml and add constants to the class for matching the value.

avatar Hackwar Hackwar - change - 24 Jan 2022
Labels Added: ?
Removed: ?
avatar superknutsel
superknutsel - comment - 3 Apr 2022

I have tested this item 🔴 unsuccessfully on 7e56d0b

I found that when searching for a partial or complete word the suggestion showed the result but after hitting enter there were no results show. When I revert the patch I get results for complete words when I do this, not for partial search terms.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752.

avatar superknutsel superknutsel - test_item - 3 Apr 2022 - Tested unsuccessfully
avatar Hackwar
Hackwar - comment - 17 May 2022

Thank you, @superknutsel. There was indeed a bug in the code. Can you test this again?

avatar superknutsel
superknutsel - comment - 17 May 2022

I have tested this item ✅ successfully on a1d1b4f

Hi @Hackwar I tested again and now it's working.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752.

avatar superknutsel superknutsel - test_item - 17 May 2022 - Tested successfully
avatar Hackwar
Hackwar - comment - 17 May 2022

Thank you very much.

avatar webnet-assmann webnet-assmann - test_item - 19 May 2022 - Tested successfully
avatar webnet-assmann
webnet-assmann - comment - 19 May 2022

I have tested this item ✅ successfully on a1d1b4f

Tested it with all settings of Word Match and it's working.
Thank you Hannes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752.

avatar HLeithner HLeithner - change - 2 Jun 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-02 11:47:29
Closed_By HLeithner
avatar HLeithner HLeithner - close - 2 Jun 2022
avatar HLeithner HLeithner - merge - 2 Jun 2022
avatar HLeithner
HLeithner - comment - 2 Jun 2022

Thanks

Add a Comment

Login with GitHub to post a comment