[#36748] - [4.1] Smart Search: Fix missing taxonomy language string
- Fixed in Code Base
- 3 Mar 2022
- Medium
- Build: 4.1-dev
- # 36748
- Diff
- Hackwar:4.2-finder-language
User tests: Successful: Unsuccessful:
Summary of Changes
Smart Search tries to create its own language keys for the indexed taxonomies. Unfortunately, when there is no language string for the key, we get a "Search by PLG_FINDER_QUERY_FILTER_BRANCH_S_SOMETHING" in the search form in the frontend. This PR checks if a translation for the language key exists and if there is none (and debug is not enabled) it will instead display the taxonomy title instead.
Testing Instructions
- If you don't have the effect already, we need to add a fake taxonomy. Go to plugins/finder/content/content.php and add
$item->addTaxonomy('Test', 'Strange');after line 342. - Reindex your site with the button in the backend.
- Go to the advanced search form in the frontend and see a dropdown with the label "Search by PLG_FINDER_QUERY_FILTER_BRANCH_S_TEST".
- Enable debugging and see that the string didn't change.
- Apply PR.
- See that the string didn't change with debugging enabled.
- Disable debugging.
- See now that the string is "Search by Test"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Enable debugging and see that the string didn't change.
Apply PR.
See that the string didn't change with debugging enabled.
Disable debugging.
Or can just reindex again
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36748.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36748.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36748.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-03 02:46:03 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on ee8d768
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36748.