Language Change ? Pending

User tests: Successful: 0 Unsuccessful: 1 alikon

Automatically created pull request based on core-translation repository changes

avatar joomla-translation-bot joomla-translation-bot - open - 19 Jan 2022
avatar joomla-translation-bot joomla-translation-bot - change - 19 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2022
Category Installation Language & Strings
avatar wilsonge
wilsonge - comment - 19 Jan 2022

I see %s and %d ‘a changing in the Italian pack again. Can you validate please @alikon ?

avatar alikon
alikon - comment - 19 Jan 2022

i dunno why only it-IT want to use %d instead of the %s in INSTL_DATABASE_ENCRYPTION_MSG_FILE_FIELD_BAD
for me this change it is wrong

avatar richard67
richard67 - comment - 19 Jan 2022

The text "INSTL_DATABASE_ENCRYPTION_MSG_FILE_FIELD_BAD" is used here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Helper/DatabaseHelper.php#L309
https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Helper/DatabaseHelper.php#L332
https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Helper/DatabaseHelper.php#L342

In all cases the sprintf parameter is a translated language string for a field label and so a string, so the %d is an error for sure.

avatar richard67
richard67 - comment - 20 Jan 2022

I've upvoted the already proposed correct Italian translation with %s on Crowdin .. let's hope it helps.

avatar alikon
alikon - comment - 20 Jan 2022

so we can close this pr ?

avatar richard67
richard67 - comment - 20 Jan 2022

Isn’t it updated automatically when the changed translation has been made on Crowdin?

avatar alikon
alikon - comment - 20 Jan 2022

dunno but this pr like it is , it is wrong

avatar zero-24
zero-24 - comment - 20 Jan 2022

Isn’t it updated automatically when the changed translation has been made on Crowdin?

Yes once its approved & synced back into the repo. This PR should be kept open until the next stable release is in preperation.

avatar alikon
alikon - comment - 20 Jan 2022

ok so let me mark it as unsuccessful in the hope that someone "cum grano salis"
will understand
ps
my last experience in crowdin was not useful at all

avatar alikon
alikon - comment - 20 Jan 2022

I have tested this item ? unsuccessfully on 15f4d7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36737.

avatar alikon alikon - test_item - 20 Jan 2022 - Tested unsuccessfully
avatar zero-24
zero-24 - comment - 20 Jan 2022

There is no point in testing this unsuccessful but better contact the TT in question so this can be fixed in crowdin. This PR will be open for any other installation language change which will come as we decided that we always have to update the version and the dates in the xml.

avatar alikon
alikon - comment - 20 Jan 2022

i'm out
i've already tryied to contact that "ghost team" without any feedback
now i'm tired

hope yuo'll have more success
than me

avatar alikon
alikon - comment - 20 Jan 2022

sorry to stick with rules

avatar alikon
alikon - comment - 20 Jan 2022

whatever this is simply wrong so i'll close it

avatar alikon alikon - close - 20 Jan 2022
avatar alikon alikon - change - 20 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-20 20:26:51
Closed_By alikon
Labels Added: Language Change ?
avatar zero-24
zero-24 - comment - 20 Jan 2022

As long as that issue is not fixed in crowdin this PR will come up again and again.

avatar alikon
alikon - comment - 20 Jan 2022

waiting for a good pr
sure not this 1

avatar alikon
alikon - comment - 20 Jan 2022

anyway feel free to commit this "shit" .... who cares ?

avatar zero-24
zero-24 - comment - 20 Jan 2022

I dont intent to merge this change for obvious reasons ;)

Add a Comment

Login with GitHub to post a comment