Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36735] - [4.1 Scheduled Tasks] Image path does not exist

? Language Change ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar Kostelano
Kostelano
18 Jan 2022

Pull Request for Issue # .

Summary of Changes

Create an image resizing task, select any directory you like. Then change the title of the directory you chose. Run the task. It's strange that when it's finished, we won't be told anything in the modal window, but we'll get a warning in the log file that the path to the image exists, which is not true.

avatar Kostelano Kostelano - open - 18 Jan 2022
avatar Kostelano Kostelano - change - 18 Jan 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2022
Category ⇒ Administration Language & Strings
avatar richard67
richard67 - comment - 18 Jan 2022

The changed language string is used here: https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/task/checkfiles/checkfiles.php#L86-L91 :

		if (!Folder::exists($path))
		{
			$this->logTask(Text::_('PLG_TASK_CHECK_FILES_LOG_IMAGE_PATH_NA'), 'warning');

			return TaskStatus::NO_RUN;
		}

So from code review it's clear that this PR here is right.

avatar richard67
richard67 - comment - 18 Jan 2022

I have tested this item ✅ successfully on 9e8a6a5

Code review. It's obvious that this PR is right, details see in my previous comment.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

avatar richard67 richard67 - test_item - 18 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 18 Jan 2022

I have tested this item ✅ successfully on 9e8a6a5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

avatar Quy Quy - test_item - 18 Jan 2022 - Tested successfully
avatar Quy Quy - change - 18 Jan 2022
Labels Added: ?
avatar Quy
Quy - comment - 18 Jan 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

avatar richard67 richard67 - change - 18 Jan 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 18 Jan 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

avatar Quy Quy - change - 18 Jan 2022
Status Ready to Commit ⇒ Pending
avatar richard67 richard67 - change - 18 Jan 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 18 Jan 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

avatar Kostelano Kostelano - change - 20 Jan 2022
Labels Added: ? Language Change
avatar bembelimen bembelimen - change - 25 Jan 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-01-25 15:08:46
Closed_By ⇒ bembelimen
avatar bembelimen bembelimen - close - 25 Jan 2022
avatar bembelimen bembelimen - merge - 25 Jan 2022
avatar bembelimen
bembelimen - comment - 25 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment