RTC PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar Shubhamverma2796
Shubhamverma2796
18 Jan 2022

Pull Request for Issue #36016.

Summary of Changes

Removed the hard limit for Module Tags-Popular and Module Tags-Similar.

Testing Instructions

For tags popular :

  1. Site modules--> New-->Tags-Popular.
  2. Set the maximum tags to a number > 20 and make sure that the tags are displayed correctly in the frontend.

For tags similar :

1.Site modules--> New-->Tags-similar.
2. Set the maximum items to a number > 20 and make sure that the tags are displayed correctly in the frontend

Actual result BEFORE applying this Pull Request

see #36016

Expected result AFTER applying this Pull Request

Any number is possible for both tags-popular and tags-similar.

Documentation Changes Required

avatar Shubhamverma2796 Shubhamverma2796 - open - 18 Jan 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 18 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2022
Category Modules Front End
avatar Shubhamverma2796 Shubhamverma2796 - change - 18 Jan 2022
Labels Added: PR-4.0-dev
avatar pabloarias
pabloarias - comment - 18 Jan 2022

I have tested this item successfully on 5f4e11c

Tested with PHP 8.0.10.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.

avatar pabloarias pabloarias - test_item - 18 Jan 2022 - Tested successfully
avatar richard67
richard67 - comment - 18 Jan 2022

@Shubhamverma2796 Could you extend your testing instructions to test also "Tags-Similar"? Currently there is only step 1 for "Tags-Popular", so a quick reader might test this only. Thanks in advance.

avatar Shubhamverma2796 Shubhamverma2796 - change - 18 Jan 2022
The description was changed
avatar Shubhamverma2796 Shubhamverma2796 - edited - 18 Jan 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 18 Jan 2022
The description was changed
avatar Shubhamverma2796 Shubhamverma2796 - edited - 18 Jan 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 18 Jan 2022
The description was changed
avatar Shubhamverma2796 Shubhamverma2796 - edited - 18 Jan 2022
avatar Shubhamverma2796
Shubhamverma2796 - comment - 18 Jan 2022

@Shubhamverma2796 Could you extend your testing instructions to test also "Tags-Similar"? Currently there is only step 1 for "Tags-Popular", so a quick reader might test this only. Thanks in advance.

requested changes done. Please check sir.

avatar richard67
richard67 - comment - 18 Jan 2022

requested changes done. Please check sir.

@Shubhamverma2796 Thanks. Looks ok to me. By the way, no need for "sir". We are a community and so some kind of fellows here.

@pabloarias Could you redo your test, and if not done last time then test also the "Tags-Similar" this time? Thanks in advance.

avatar pabloarias
pabloarias - comment - 21 Jan 2022

I've added example tags to more articles and tested Tags-Similar module. It works fine!

Tested with options All, Any and Half in Match Type. Also tested with different orders results.

avatar pabloarias
pabloarias - comment - 21 Jan 2022

I have tested this item successfully on efd471f

I've uninstalled the path, fetched data from Github and installed the path again.

After that I've been playing with order, direction and font size in Cloud Layout.

It seems to work perfectly! Thank you very much!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.

avatar pabloarias pabloarias - test_item - 21 Jan 2022 - Tested successfully
avatar BertaOctech
BertaOctech - comment - 21 Jan 2022

I have tested this item successfully on efd471f

Hi,
it worked as expected for me, too.
Once applied the patch I was able to show more than 20 tags in the popular tags module and more than 20 items in the similar tags module.
They were displayed correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.

avatar BertaOctech BertaOctech - test_item - 21 Jan 2022 - Tested successfully
avatar Quy Quy - change - 21 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 21 Jan 2022

Thanks to everyone

avatar bembelimen bembelimen - close - 22 Jan 2022
avatar bembelimen bembelimen - merge - 22 Jan 2022
avatar bembelimen bembelimen - change - 22 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-22 20:44:10
Closed_By bembelimen
Labels Added: RTC
avatar bembelimen
bembelimen - comment - 22 Jan 2022

Thx

avatar Shubhamverma2796
Shubhamverma2796 - comment - 22 Jan 2022

Thanks for merging.

Add a Comment

Login with GitHub to post a comment