[#36732] - Removed hard limit of 20 to the module tags
- Fixed in Code Base
- 22 Jan 2022
- Medium
- Build: 4.0-dev
- # 36732
- Diff
- Shubhamverma2796:issue_36016
User tests: Successful: Unsuccessful:
Pull Request for Issue #36016.
Summary of Changes
Removed the hard limit for Module Tags-Popular and Module Tags-Similar.
Testing Instructions
For tags popular :
- Site modules--> New-->Tags-Popular.
- Set the maximum tags to a number > 20 and make sure that the tags are displayed correctly in the frontend.
For tags similar :
1.Site modules--> New-->Tags-similar.
2. Set the maximum items to a number > 20 and make sure that the tags are displayed correctly in the frontend
Actual result BEFORE applying this Pull Request
see #36016
Expected result AFTER applying this Pull Request
Any number is possible for both tags-popular and tags-similar.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
@Shubhamverma2796 Could you extend your testing instructions to test also "Tags-Similar"? Currently there is only step 1 for "Tags-Popular", so a quick reader might test this only. Thanks in advance.
@Shubhamverma2796 Could you extend your testing instructions to test also "Tags-Similar"? Currently there is only step 1 for "Tags-Popular", so a quick reader might test this only. Thanks in advance.
requested changes done. Please check sir.
requested changes done. Please check sir.
@Shubhamverma2796 Thanks. Looks ok to me. By the way, no need for "sir". We are a community and so some kind of fellows here.
@pabloarias Could you redo your test, and if not done last time then test also the "Tags-Similar" this time? Thanks in advance.
I've added example tags to more articles and tested Tags-Similar module. It works fine!
Tested with options All, Any and Half in Match Type. Also tested with different orders results.
I have tested this item
I've uninstalled the path, fetched data from Github and installed the path again.
After that I've been playing with order, direction and font size in Cloud Layout.
It seems to work perfectly! Thank you very much!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.
I have tested this item
Hi,
it worked as expected for me, too.
Once applied the patch I was able to show more than 20 tags in the popular tags module and more than 20 items in the similar tags module.
They were displayed correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.
Thanks to everyone
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-22 20:44:10 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
Thanks for merging.
I have tested this item✅ successfully on 5f4e11c
Tested with PHP 8.0.10.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36732.