? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
16 Jan 2022

Code review

A set of manually changed micro optimisations, targeted at 4.1 to prevent as many PR conflicts as possible (And I will personally fix any PR conflicts if there are)

Non exhaustive, as was prepared on the sofa on Sunday afternoon lazy time. Plus if I did them all in the same PR (800+ files!) then it would have no chance of being merged.

Also reverts some previous optimisation in administrator/components/com_admin/script.php, but that file is not namespace so its not needed in that file.

avatar PhilETaylor PhilETaylor - open - 16 Jan 2022
avatar PhilETaylor PhilETaylor - change - 16 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2022
Category Administration com_admin com_associations com_banners com_cache com_categories
avatar PhilETaylor PhilETaylor - change - 16 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 16 Jan 2022
avatar PhilETaylor PhilETaylor - change - 16 Jan 2022
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 16 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 16 Jan 2022
avatar alikon
alikon - comment - 20 Jan 2022

I have tested this item successfully on e6222e8

code review
+
having this pr applyed for a while


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36711.

avatar alikon alikon - test_item - 20 Jan 2022 - Tested successfully
avatar PhilETaylor PhilETaylor - change - 20 Jan 2022
Labels Added: Conflicting Files
avatar PhilETaylor
PhilETaylor - comment - 20 Jan 2022

@alikon added the Conflicting Files label 23 seconds ago

I see no conflicts?

avatar alikon
alikon - comment - 20 Jan 2022

yeah wrong wording, sorry

avatar Quy
Quy - comment - 20 Jan 2022

I have tested this item successfully on 49f50e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36711.

avatar Quy Quy - test_item - 20 Jan 2022 - Tested successfully
avatar Quy Quy - alter_testresult - 20 Jan 2022 - alikon: Tested successfully
avatar Quy Quy - change - 20 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36711.

avatar bembelimen bembelimen - close - 31 Jan 2022
avatar bembelimen bembelimen - merge - 31 Jan 2022
avatar bembelimen bembelimen - change - 31 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-31 15:58:52
Closed_By bembelimen
Labels Added: ?
Removed: Conflicting Files
avatar bembelimen
bembelimen - comment - 31 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment