[#36706] - [4.1] Flags (alternate)
- Fixed in Code Base
- 20 Jan 2022
- Medium
- Build: 4.1-dev
- # 36706
- Diff
- brianteeman:flags_alt
User tests: Successful: Unsuccessful:
alternate to #36609
Some flags have a white background and so they do not display correctly. This is particularly true for the japanese flag but its true for other flags as well. This adds super thin border to flags with a white edge
Before
After
As this is a media file change it needs npm i
lets not start another debat here about not using flags or not usings gifs
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36706.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36706.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-20 03:02:18 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
I guess we have the same problem with all the other flags if a color of the flag is used as background colour of the template (e.g. in frontend with the language switcher). So probably, we should update all flags sometimes in the future.
So far to fix the obvious ones this is a good start. Thx.
Thanks for merging.
Now that all the flags have a solid border then css would be a better solution if there is a dark background colour that clashes.
I have tested this item✅ successfully on 8a79b09
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36706.