User tests: Successful: Unsuccessful:
Pull Request for Issue #36669 .
Remove JPATH_ROOT from absolute file path only if JPATH_ROOT is at beginning of string
Added by rdeutz
If JPATH_ROOT is repeated inside file names, resources are not getting loaded.
Example:
JPATH_ROOT = '/joomla'
$path = '/joomla/media/system/images/joomla-favicon.svg'
Wrong output before: /media/system/images-favicon.svg
Another less unusual example:
JPATH_ROOT = '/app/html
$path = '/app/html/media/com_something/js/app/html_custom.js'
Wrong output before: /media/com_something/js_custom.js
If JPATH_ROOT is present 2 times in the $path, it will be removed only if at beginning (where it should be)
Example:
JPATH_ROOT = '/joomla'
$path = '/joomla/media/system/images/joomla-favicon.svg'
Correct output with patch: /media/system/images/joomla-favicon.svg
Another less unusual example:
JPATH_ROOT = '/app/html
$path = '/app/html/media/com_something/js/app/html_custom.js'
Wrong output before: /media/com_something/js/app/html_custom.js
Problem was not declared anywhere else
Code run as before (JPATH_ROOT is not supposed to be in the middle of the $path if not for casuality)
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
PBF
bug
Small
PR-4.4-dev
PR-5.2-dev
Removed: ? ? |
||
| Labels |
Removed:
PR-4.4-dev
|
||
| Labels |
Added:
Updates Requested
|
||
| Title |
|
||||||
Added testing instructions and tested successfully
I have tested this item ✅ successfully on d47f76c
I have tested this item ✅ successfully on d47f76c
On windows, it's hard to follow the instructions. But I reviewed code, also tried to using media manager, navigate to different pages and do not see any error.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
| Labels |
Added:
RTC
Removed: Updates Requested PBF |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-19 11:33:05 |
| Closed_By | ⇒ | LadySolveig |
I have tested this item ✅ successfully on 61863c9
@michaelmaass Hmm, it doesn't make much sense to test a pull request which was merged long time ago and so is included since Joomla 5.2. Are you sure you marked the right one?
@michaelmaass Hmm, it doesn't make much sense to test a pull request which was merged long time ago and so is included since Joomla 5.2. Are you sure you marked the right one?
Yes, sorry for the confusion.
I had tested it quite a long time ago but only now learned how to correctly create the appropriate response ... and clearly missed the boat.
This pull request has automatically rebased to 4.2-dev.