Feeling Lucky
?
?
[#36673] - [4.0] Return value type is not compatible with declared
- Fixed in Code Base
- 21 Jan 2022
- Medium
- Build: 4.0-dev
- # 36673
- Diff
- PhilETaylor:20220113-4.0-returntypes
User tests: Successful: Unsuccessful:
Code review
Return value type is not compatible with declared
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_config com_finder com_media com_menus Front End com_users Libraries |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 15 Jan 2022
This is not an exhaustive PR, Joomla is full of these incorrect types! It’s going to take years to correct them all
Sent from my iPhone
On 15 Jan 2022, at 10:26, jsanders @.***> wrote:
should be * @return string
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
sandewt
- comment
- 15 Jan 2022
Obviously, I already suspected that.
Great that you have made a start.
sandewt
- comment
- 15 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36673.
Quy
- comment
- 15 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36673.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 15 Jan 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36673.
PhilETaylor
- comment
- 15 Jan 2022
Thanks
pritam825
- comment
- 18 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36673.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-21 12:57:01 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 21 Jan 2022
Thx
joomla-cms/administrator/components/com_associations/src/Helper/AssociationsHelper.php
Line 179 in 51d9531
should be
* @return string