Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar niharikamahajan02
niharikamahajan02
12 Jan 2022

Pull Request for Issue #36453 (Part 2).

Summary of Changes

The ACL Permission also renaming and column header test task renamed to run task.

avatar niharikamahajan02 niharikamahajan02 - open - 12 Jan 2022
avatar niharikamahajan02 niharikamahajan02 - change - 12 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2022
Category Administration Language & Strings
avatar tecpromotion
tecpromotion - comment - 12 Jan 2022

I have tested this item ? unsuccessfully on be523c4

@niharikamahajan02 if you change the value for the string COM_SCHEDULER_PERMISSION_TASKRUN, then the constant must also be changed, right?

See

<action name="core.testrun" title="COM_SCHEDULER_PERMISSION_TESTRUN" />
and
<action name="core.testrun" title="COM_SCHEDULER_PERMISSION_TESTRUN" />

otherwise, unfortunately, this does not work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36664.

avatar tecpromotion tecpromotion - test_item - 12 Jan 2022 - Tested unsuccessfully
avatar richard67
richard67 - comment - 12 Jan 2022

@niharikamahajan02 Does this replace your other PR #36656 ? If so, then please close that other one. We do not need lots of duplicate PRs here in this repository.

avatar tecpromotion
tecpromotion - comment - 13 Jan 2022

@niharikamahajan02 Does this replace your other PR #36656 ? If so, then please close that other one. We do not need lots of duplicate PRs here in this repository.

Perhaps both should be closed and a new and clean PR with all the incidents submitted as PR.

avatar niharikamahajan02
niharikamahajan02 - comment - 13 Jan 2022

@niharikamahajan02 Does this replace your other PR #36656 ? If so, then please close that other one. We do not need lots of duplicate PRs here in this repository.

Perhaps both should be closed and a new and clean PR with all the incidents submitted as PR.

Ok sir , would submit a new PR with required changes suggested by you. Thanks.

avatar bembelimen bembelimen - change - 14 Jan 2022
Labels Added: Language Change ?
avatar bembelimen
bembelimen - comment - 14 Jan 2022

I would prefere to have this PR here the way like it is.

avatar richard67
richard67 - comment - 14 Jan 2022

I would prefere to have this PR here the way like it is.

@niharikamahajan02 Could you close your other PR #36656 then? It seems to be duplicate to this one here. Thanks in advance.

avatar richard67
richard67 - comment - 14 Jan 2022

P.S.: And #36655 and #36607 too, they seem to be also duplicates to be closed.

avatar tecpromotion
tecpromotion - comment - 14 Jan 2022

I would prefere to have this PR here the way like it is.

But it doesn't work like that without further adjustments.

avatar niharikamahajan02
niharikamahajan02 - comment - 15 Jan 2022

P.S.: And #36655 and #36607 too, they seem to be also duplicates to be closed.

Yes , I have closed those PR now.

avatar niharikamahajan02
niharikamahajan02 - comment - 15 Jan 2022

I would prefere to have this PR here the way like it is.

But it doesn't work like that without further adjustments.

Yes , @bembelimen sir that's why I thought to make a new PR with suggested changes.

avatar tecpromotion
tecpromotion - comment - 15 Jan 2022

I would prefere to have this PR here the way like it is.

But it doesn't work like that without further adjustments.

Yes , @bembelimen sir that's why I thought to make a new PR with suggested changes.

That is good. However, there are then many more adjustments that are necessary here to make it clean.

avatar tecpromotion
tecpromotion - comment - 15 Jan 2022

I think it is easier to close this PR as well and submit all the necessary amendments collectively in PR #36656.

avatar niharikamahajan02 niharikamahajan02 - change - 15 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-15 11:50:20
Closed_By niharikamahajan02
avatar niharikamahajan02 niharikamahajan02 - close - 15 Jan 2022

Add a Comment

Login with GitHub to post a comment