[#36663] - [6.0] FileLayout instantiation limitation in ToolbarButton::renderButton() removed
- Pending
- Medium
- Build: 4.1-dev
- # 36663
- Diff
- akshitrattan:Fixed-36579
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #36597 .
Summary of Changes
override the renderButton() method in ToolbarButton to remove the limitations of FileLayout Instantiation in modules tab
Testing Instructions
Create a module that uses button layout from a component
if you are able to access the component button layout, the test is successful.
Actual result BEFORE applying this Pull Request
Firstly, create a module that uses button layout from a component
Earlier, you were unable to access the component button layout.
Expected result AFTER applying this Pull Request
after the commit, you will be able to access the component button layout.
Documentation Changes Required
No major changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
This pull request has been automatically rebased to 4.3-dev.
Thank you Akshit @akshitrattan for this PR.
I have asked the maintainers about the implementation and it looks like it would be best to make it similar to the FormField class and call getRenderer()
joomla-cms/libraries/src/Form/FormField.php
Line 1331 in e2170c8
| Title |
|
||||||
@BrainforgeUK can you give an example code how this should work? wouldn't it be enough to add options to the renderButton option array which can be used for the basePath and the options on FileLayout?
also pining @akshitrattan
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
This pull request has automatically rebased to 4.2-dev.