[#36653] - [4.1] Fix Image Size Check with scheduler
- Fixed in Code Base
- 14 Jan 2022
- Medium
- Build: 4.1-dev
- # 36653
- Diff
- bembelimen:4.1/fix-filesize-task
User tests: Successful: Unsuccessful:
Summary of Changes
- Fix the resizing of the image with the scheduler task
- Improve the description to make aware, that the file will be overwritten
Testing Instructions
- Create a task from the type "Image Size Check"
- Run it
Actual result BEFORE applying this Pull Request
Image sizes are not changed.
Expected result AFTER applying this Pull Request
Image sizes are changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.
Then it must be clearly documented otherwise it will appear to be broken.
Although I have to say if it only does one image per run then it is pretty useless
| Labels |
Added:
Language Change
?
|
||
Updated the PR to allow more than one image per run.
Now I get this error:
Folder Sample Data. Fresh installation of the full package.
Maybe only my local environment: ERROR Routine threw exception: The GD extension for PHP is not available.
I have tested this item
Tested with 1 image, it works. Changed the settings to maximum images = 3, uploaded 4 big images, 3 where changed successfully on the next run. The 4th image was changed too in the next run.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.
I have tested this item
Re-tested on web server and it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-14 18:28:45 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thanks all for the feedback and the improvements.
I have tested this item? unsuccessfully on 4b49ad2
Resizes the first image found that is too big but then says its completed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.