No Code Attached Yet
avatar brianteeman
brianteeman
11 Jan 2022

Steps to reproduce the issue

Install joomla 3.10 on php 7.0
On completion set the joonla update channel to Joomla Next
Update Joomla

Expected result

The pre-update check fails because the version of php is below the minimum

Actual result

The pre-update check is checking for the php requirements of joomla 3 not joomla 4

image

System information (as much as possible)

Additional comments

avatar brianteeman brianteeman - open - 11 Jan 2022
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Jan 2022
avatar zero-24
zero-24 - comment - 11 Jan 2022

Yes this is a known issue and a dublicate of: #36610 (comment) So Imo this here can be closed right?

avatar alikon
alikon - comment - 11 Jan 2022

humm
i've understood the issue reading this one,
anyway
i'll let the pr maker choose which it prefer to close first
?

avatar brianteeman
brianteeman - comment - 11 Jan 2022

I dont believe its a duplicate because I believe the description on yours is misleading/wrong

The reason that you see "PHP Version >= 5.3.10" is because 5.3.10 is the fallback string when the real update information is not found. Having said that I cannot find anywhere or any means for the correct php minimum requirements ever to be found.

	/**
	 * Returns the PHP minimum version for the update.
	 * Returns JOOMLA_MINIMUM_PHP, if there is no information given.
	 *
	 * @return string
	 *
	 * @since 3.10.0
	 */
	private function getTargetMinimumPHPVersion()
	{
		$updateInformation = $this->getUpdateInformation();

		return isset($updateInformation['object']->php_minimum) ?
			$updateInformation['object']->php_minimum->_data :
			JOOMLA_MINIMUM_PHP;
	}

THIS IS A RELEASE BLOCKER

avatar zero-24
zero-24 - comment - 11 Jan 2022

I dont believe its a duplicate because I believe the description on yours is misleading/wrong

I tried to explain the technical reason that the information is not aviable, maybe it was not good enough. In the end its the same root cause and similiar to what george wrote on the other issue too.

avatar alikon alikon - change - 11 Jan 2022
Labels Added: Release Blocker
avatar alikon alikon - labeled - 11 Jan 2022
avatar alikon
alikon - comment - 11 Jan 2022

btw let's focus on this a bit more

avatar brianteeman
brianteeman - comment - 11 Jan 2022

Your description is wrong.
You are saying that the code to do the check is not taking place.
I am saying that it can never take place because the information does not exist

avatar zero-24
zero-24 - comment - 11 Jan 2022

You are saying that the code to do the check is not taking place.

Again maybe my description is not good. But the check takes place and works as designed for now. As it pre dates the pre upgrade checker the filtering is already happening in JUpdate and when the version (php or mysql or stability) is not meet jupdate reports "we have found an update but no update object to download it" And as that update object is not aviable it does not have the correct versions and falls back to the minimum version set in the CMS.

avatar brianteeman
brianteeman - comment - 11 Jan 2022

But the check takes place and works as designed for now.

Where do we define that the minimum for php in j4 is xxxxx

avatar brianteeman brianteeman - change - 11 Jan 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-01-11 18:44:39
Closed_By brianteeman
avatar brianteeman brianteeman - close - 11 Jan 2022
avatar brianteeman
brianteeman - comment - 11 Jan 2022

not wasting more time

avatar zero-24
zero-24 - comment - 11 Jan 2022
avatar zero-24 zero-24 - change - 11 Jan 2022
Labels Removed: Release Blocker
avatar zero-24 zero-24 - unlabeled - 11 Jan 2022

Add a Comment

Login with GitHub to post a comment