Joomla! Issue Tracker | Joomla! CMS #36623 - [4.0] deprecation warning inside mod

No Code Attached Yet

Closed
10 Jan 2022
Medium
Build: 4.0-dev
# 36623

elpescador-nl
9 Jan 2022

Steps to reproduce the issue

Add a banner module without header/footer text

Expected result

No deprecation warning

Actual result

A deprecation warning:

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /path/to/joomla4/modules/mod_banners/mod_banners.php on line 16

System information (as much as possible)

Joomla! 4.0.5
php 8.1.1

elpescador-nl - open - 9 Jan 2022

joomla-cms-bot - change - 9 Jan 2022

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 9 Jan 2022

elpescador-nl - comment - 9 Jan 2022

This:

joomla-cms/modules/mod_banners/mod_banners.php

Lines 16 to 17 in ca0c42d

    
           $headerText = trim($params->get('header_text')); 
        
           $footerText = trim($params->get('footer_text'));

Replaced by this, might be the simplest solution:

 $headerText = trim($params->get('header_text', '')); 
 $footerText = trim($params->get('footer_text', ''));

PhilETaylor - comment - 10 Jan 2022

#36625

alikon - change - 10 Jan 2022

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-01-10 07:13:24
Closed_By		⇒	alikon

alikon - close - 10 Jan 2022

alikon - comment - 10 Jan 2022

please test #36625

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#36623] - [4.0] deprecation warning inside mod_banners in php 8.1

Steps to reproduce the issue

Expected result

Actual result

System information (as much as possible)

Add a Comment

	$headerText = trim($params->get('header_text'));
	$footerText = trim($params->get('footer_text'));