Feeling Lucky
?
?
[#36613] - [3.10] Backport the image Layout
- Fixed in Code Base
- 29 Jan 2022
- Medium
- Build: 3.10-dev
- # 36613
- Diff
- dgrammatiko:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR backports the image.php JLayout so Devs could use it even if their extensions are targeting both 3.10 and 4.x
Testing Instructions
in the protostar index.php add before the <Jdoc:include type="component" the following
<?php echo JLayoutHelper::render(
'joomla.html.image',
[
'src' => JUri:root() . 'images/joomla_black.png',
'alt' => 'Some Alt tag',
]
); ?>
<?php echo JLayoutHelper::render(
'joomla.html.image',
[
'src' => JUri:root() . 'iimages/powered_by.png',
'alt' => false,
]
); ?>You should be able to see the 2 Joomla banners, one with alt: Some Alt tag and the other one without any alt tag
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Yes, this needs to be communicated, eg: this is the preferred way to handle images.
I'm preparing something...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
laoneo
- comment
- 10 Jan 2022
I have tested this item
test code is wrong, after i fixed, it worked
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36613.
Quy
- comment
- 10 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36613.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 10 Jan 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36613.
| Labels |
Added:
?
|
||
zero-24
- comment
- 29 Jan 2022
Merging here thanks :)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-29 19:09:25 |
| Closed_By | ⇒ | zero-24 |
Getting the following warnings:
Warning: Undefined variable $img in /var/www/html/pr/36613/layouts/joomla/html/image.php on line 21
Warning: Attempt to read property "url" on null in /var/www/html/pr/36613/layouts/joomla/html/image.php on line 21