? ? ? Pending

User tests: Successful: Unsuccessful:

avatar tQuant
tQuant
28 May 2014

This PR adds "clean up on paste" option to TinyMCE settings. I think this is very basic and usefull settings.

For example, if you copy just 4 short string from MS Word document (attached to tracker item: http://joomlacode.org/gf/download/trackeritem/33796/159223/List%20for%20example.docx) to TinyMCE, then you will get plenty of garbage code: http://pastebin.com/7S43SQhC

If you apply PR and enable "clean up on paste" option, then when copying the same document to TinyMCE you will get this: http://pastebin.com/cwzE8Tqn

Tracker item

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33796&start=0

avatar tQuant tQuant - open - 28 May 2014
avatar tQuant tQuant - change - 28 May 2014
Title
TinyMCE clean up on paste
[#33796] TinyMCE clean up on paste
avatar infograf768
infograf768 - comment - 30 May 2014

Not sure about this patch:
Should not the default be to ON
It looks to me that one never wants to get the MSWord html mess, therefore should not it just be added as always true?

avatar tQuant
tQuant - comment - 30 May 2014

I totally agree with you, I'm just not familiar with the Joomla policy about changing the default behavior. And because in Joomla this feature is not used so far, then to not change habitual behavior, I turned off this option by default.
If you want, I can change it.

avatar infograf768
infograf768 - comment - 30 May 2014

I see now better the issue in your patch:
You added the paste plugin in "Advanced mode" although we never include the plugin there

As we indeed only propose the paste plugin in Extended mode, this change

  • plugins : \"table link image code charmap autolink lists importcss\",
  • plugins : \"table link image code charmap autolink lists importcss $cleanUpPlugin\",

is useless
as well as the definitions for $cleanUpPlugin as the paste plugin will be loaded by

if (!$paste)
+           {
+               $plugins[] = 'paste';
``
+           }

Also please indeed default option to ON.

avatar tQuant
tQuant - comment - 30 May 2014

If I remove 'paste' plugin from "Advanced mode", then 'clean up' option will works only in "Extended mode".
So the question is: should it work in Simple and Advanced mode or only in Extended?
If it should work in Simple mode, then should I move option from 'Advanced' tab to main tab?

avatar dgt41
dgt41 - comment - 31 May 2014

Go for Simple and default ON :+1:

avatar infograf768
infograf768 - comment - 31 May 2014

As we use Paste only in extended mode, I guess we should implement clean up on paste there only.
This would be the most B/C imho

avatar Erik-van-Doorne
Erik-van-Doorne - comment - 31 May 2014

@tested=OK

avatar tQuant
tQuant - comment - 1 Jun 2014

Ok, now 'clean up' option works only in extended mode. So to test it, you need to switch to extended mode.
I hope in newer versions of Joomla! (at least 4.0) we can turn on this option by default for all modes, since B/C there is not so important.

avatar tQuant
tQuant - comment - 3 Jun 2014

Incidentally, in the extended mode clean up happens without this PR (perhaps in another way). Therefore, if the use of cleaning up is not planned for the simple and advanced mode, this PR can be closed.

avatar infograf768
infograf768 - comment - 3 Jun 2014

I suggest we discuss this on list

also, we just merged Tiny 4.0.28 version. Please test again with master

avatar tQuant
tQuant - comment - 3 Jun 2014

It seems that parameter 'paste_auto_cleanup_on_paste' not work in Tiny 4.
If 'paste' plugin is loaded then clean up on paste works, otherwise - not.

Changes necessary to add 'clean up' to extended mode only:
https://github.com/tQuant/joomla-cms/compare/cleanUpExtendedMode
To all modes:
https://github.com/tQuant/joomla-cms/compare/cleanUpAllModes

avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
The description was changed
Status New Pending
avatar zero-24
zero-24 - comment - 13 Mar 2015

@tQuant can you update your branche to staging?

avatar asysta asysta - test_item - 14 Mar 2015 - Tested successfully
avatar mdemop mdemop - test_item - 19 Jul 2015 - Tested unsuccessfully
avatar designbengel designbengel - test_item - 24 Oct 2015 - Tested unsuccessfully
avatar designbengel
designbengel - comment - 24 Oct 2015

I have tested this item :red_circle: unsuccessfully on 9c93fa0

Still stuff added like "" and on...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3661.

avatar brianteeman brianteeman - change - 12 Nov 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-11-12 17:17:57
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 12 Nov 2015

I am closing this as it can not work
The code in this PR simply called a tinymce version 3 plugin
We are using tinymce 4 now and the plugins for tinymce and their syntax is different


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3661.

avatar brianteeman brianteeman - close - 12 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment