Feeling Lucky
?
[#36603] - [3] don't remove emailcloack from module
- Closed
- 16 Jun 2022
- Medium
- Build: 3.10-dev
- # 36603
- Diff
- alikon:patch-4
User tests: Successful: Unsuccessful:
Pull Request for Issue #13522.
Summary of Changes
don't remove <joomla-hidden-mail>
Testing Instructions
- Add an "Articles Category" module on the sample site
- Under "Display Options" tab: everything on Hide, except "Introtext= show" and "Show Read More=show"
- Create an article with the below html:
<p>Intro text <a href="mailto:sample@example.com">sample@example.com</a> - more more more</p>
<hr id="system-readmore" />
<p><br />Paragraph 1<br />1<br />2<br />3<br />4<br />5</p>
<p>Paragraph 2<br />1<br />2<br />3<br />4<br />5</p>
<p>Paragraph 3<br />1<br />2<br />3<br />4<br />5</p>
<p>End</p>
Actual result BEFORE applying this Pull Request
This email address is being protected from spambots. You need JavaScript enabled to...
Expected result AFTER applying this Pull Request
Introtext shows the email address
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
| Labels |
Added:
?
|
||
jsubri
- comment
- 9 Jan 2022
I have tested this item
Now respecting the show/hide Introtext pointed out by @Fedik
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36603.
Fedik
- comment
- 10 Jan 2022
I just found, changing the code ordering may break more than fix.
Example if Article contain "loadmodule/loadposition" tag:
<p>{loadposition navigation}</p>
<p>Intro text <a href="mailto:sample@example.com">sample@example.com</a> - more more more</p>
<hr id="system-readmore" />
<p><br />Paragraph 1<br />1<br />2<br />3<br />4<br />5</p>
<p>Paragraph 2<br />1<br />2<br />3<br />4<br />5</p>
<p>Paragraph 3<br />1<br />2<br />3<br />4<br />5</p>
<p>End</p>
Then whole content will be rendered.
Need to find another way.
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-16 15:55:10 |
| Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on ec6ea54
Clever fix
Before the patch the javascript is render "document.getElementById('cloak1bb8d18fc01bde967325b35c999b2ffa').inner..."
After, works as expected
tested on 3.9.x and 3.10.4, not test tested on J4
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36603.