Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36598] - [4.0] Load the subform data correctly

? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
7 Jan 2022

Summary of Changes

The FormField should load the form data from the actual aclass and not the parent. With the current code it is not possible to overload the from data.

Testing Instructions

  • Add the following code to the file /libraries/src/Form/Field/AccessiblemediaField.php:
protected function getLayoutData()
{
    $data = parent::getLayoutData();
    $data['class'] .= ' test';
    return $data;
}
  • Replace the line 19 in the file /layouts/joomla/form/field/media/accessiblemedia.php with:
<div class="subform-wrapper <?php echo $class;?>">
  • Create a media custom field
  • Open the article form

Actual result BEFORE applying this Pull Request

The root container of the media custom field has no class test.

Expected result AFTER applying this Pull Request

The root container of the media custom field has the class test.

avatar laoneo laoneo - open - 7 Jan 2022
avatar laoneo laoneo - change - 7 Jan 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2022
Category ⇒ Libraries
avatar laoneo
laoneo - comment - 7 Jan 2022

@Fedik can you have a look here as you are the subform guru

avatar Fedik
Fedik - comment - 7 Jan 2022

I have tested this item ✅ successfully on 339163c

Yea, that is correct, probably a little typo :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36598.

avatar Fedik Fedik - test_item - 7 Jan 2022 - Tested successfully
avatar laoneo
laoneo - comment - 7 Jan 2022

A little typo for you but a big issue for me ?

avatar laoneo laoneo - change - 7 Jan 2022
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 8 Jan 2022

I have tested this item ✅ successfully on 05a45f6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36598.

avatar dgrammatiko dgrammatiko - test_item - 8 Jan 2022 - Tested successfully
avatar alikon
alikon - comment - 8 Jan 2022

I have tested this item ? unsuccessfully on 05a45f6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36598.

avatar alikon alikon - test_item - 8 Jan 2022 - Tested unsuccessfully
avatar alikon alikon - alter_testresult - 8 Jan 2022 - alikon: Tested successfully
avatar alikon alikon - change - 8 Jan 2022
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 8 Jan 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36598.

avatar laoneo
laoneo - comment - 8 Jan 2022

@alikon what was wrong with your test?

avatar alikon alikon - alter_testresult - 8 Jan 2022 - alikon: Tested successfully
avatar alikon
alikon - comment - 8 Jan 2022

nothing hit the wrong button

avatar wilsonge wilsonge - change - 8 Jan 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-01-08 18:47:05
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 8 Jan 2022
avatar wilsonge wilsonge - merge - 8 Jan 2022
avatar wilsonge
wilsonge - comment - 8 Jan 2022

Thanks!

Add a Comment

Login with GitHub to post a comment