Feeling Lucky
?
[#36574] - [4.1] Fix the update failure on Windows
- Closed
- 5 Jan 2022
- Medium
- Build: 4.1-dev
- # 36574
- Diff
- dgrammatiko:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue #36567 .
Summary of Changes
Upgrading from 4.0.x to 4.1 fails due to some FS inconsistencies
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 5 Jan 2022
if your using real_path my point is you shouldn't need the str_replace on top of that
dgrammatiko
- comment
- 5 Jan 2022
if your using real_path my point is you shouldn't need the str_replace on top of that
I don't have a windows PC so I try things blindly here. Will remove them
brianteeman
- comment
- 5 Jan 2022
its nothing to do with the file path as expained in the other issue
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-05 18:57:58 |
| Closed_By | ⇒ | dgrammatiko |
Isn't just you need to wrap the function call in realpath for Folder::exists. because realpath will do the path conversion for slashes (see the second example here https://www.php.net/manual/en/function.realpath.php)