[#36505] - [4] Fix pass-by-reference regression in PlgContentEmailcloak
- Fixed in Code Base
- 1 Jan 2022
- Medium
- Build: 4.0-dev
- # 36505
- Diff
- PhilETaylor:fixemailclockbypassbyreference
User tests: Successful: Unsuccessful:
Pull Request for Issue #36501 fixes regression from my PR #36442
Summary of Changes
Only parameters can be passed by reference - doh.
Testing Instructions
Create an article with an email address in it - view article on frontend
Actual result BEFORE applying this Pull Request
PlgContentEmailcloak::_cloak(): Argument #1 ($text) cannot be passed by reference
Expected result AFTER applying this Pull Request
Article loads fine.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
The problem is, that you assign the text to the $text variable, so there is no reference to the original object anymore. This means, emails will not be "encrypted" (yeah, I know...).
Test case
Insert an email into an article (without linking)
Expected result
Email encrypted and linked
Current result
Email just plain text
Solution
Revert to old code
if (is_object($row))
{
$this->_cloak($row->text, $params);
return;
}
$this->_cloak($row, $params);
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36505.
Makes sense - thanks.
I have tested this item
Tested in 4.1 beta3, php 8.0.14. Everything fine now, the E-mail address is "encrypted", accessibility checker does not complain :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36505.
I have tested this item
Thank you, it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36505.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36505.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-01 09:54:58 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on 75a58d8
Tested works now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36505.