? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
30 Dec 2021

Reverts #36483

@PhilETaylor this broke the composer autoloading (apparently drone didn't fail because it still uses composer v1 ? ). But if you look at the original PR "composer" section in Drone you can see the warnings for composer v2

avatar wilsonge wilsonge - open - 30 Dec 2021
avatar wilsonge wilsonge - change - 30 Dec 2021
Status New Pending
avatar wilsonge wilsonge - close - 30 Dec 2021
avatar wilsonge wilsonge - merge - 30 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2021
Category Unit Tests
avatar wilsonge wilsonge - change - 30 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-30 21:46:35
Closed_By wilsonge
Labels Added: ? ?
avatar PhilETaylor
PhilETaylor - comment - 30 Dec 2021

Hmmm works on my machine :-) and I use snapshot composer

I’ll look again as this change is the right thing to do

avatar wilsonge
wilsonge - comment - 30 Dec 2021

For sure - otherwise I wouldn't have merged it :) Just definitely screws with the composer autoload here I think https://github.com/joomla/joomla-cms/blob/4.0-dev/composer.json#L30-L34 - if we go down this route I think we have to re-amend all the namespaces (or change the autoloading method)

avatar PhilETaylor
PhilETaylor - comment - 30 Dec 2021

I guess what this also shows is that we are using Composer 1 when Composer 2 is the new norm ;-)

Leave it with me, I'll take another stab tomorrow.

Add a Comment

Login with GitHub to post a comment