Feeling Lucky
?
[#36489] - [4.0] If the Mail Template was not found in the db, return false
- Fixed in Code Base
- 4 Jan 2022
- Medium
- Build: 4.0-dev
- # 36489
- Diff
- PhilETaylor:patch-332
User tests: Successful: Unsuccessful:
Pull Request for Issue #36478
Summary of Changes
If the Mail Template was not found in the db, we cannot send an email, therefore return false before trying to do lots of things based on the template that doesnt exist and avoid error messages
Testing Instructions
Code review
$mailer = new MailTemplate('com_bftest.invalidtemplateid', 'en-GB');
// ...
$sent = $mailer->send();Actual result BEFORE applying this Pull Request
Load of PHP notices and a 'Message body empty' warning.
Expected result AFTER applying this Pull Request
// $sent === false
$sent = $mailer->send();Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
wilsonge
- comment
- 31 Dec 2021
I would write a Unit test for this but... ComponentHelper::getParams /facepalm/ and static calls cannot be mocked :(
I mean if you really wanna go ham - which I strongly encourage of course :) You should be able to mock the params in the db I think. I'll see if I can dig out an example tomorrow.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-04 17:16:55 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 4 Jan 2022
Thanks!
I would write a Unit test for this but...
ComponentHelper::getParams/facepalm/ and static calls cannot be mocked :(