[#36482] - [4][com_finder] - php 8.1 serializable-deprecated with unit test
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 36482
- Diff
- PhilETaylor:php81findercornflakes
User tests: Successful: Unsuccessful:
replacement of #36473 with Unit tests that run before and after with success (although correctly, before this PR the unit test has the deprecation warning.
Summary of Changes
added magic method
Testing Instructions
php 8.1
on frontend do a search
check the log
Actual result BEFORE applying this Pull Request
PHP Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)
Expected result AFTER applying this Pull Request
no more deprecation
Note
This is our FIRST EVER Unit test for a method in Joomla 4 Extensions it seems... woot woot (also see: #36483)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Unit Tests |
Drone failure unrelated to PR content.
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
|
||
I have tested this item
on php 7.4 and php 8.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36482.
Can you make an update to the branch to retrigger drone (emojis in the description... I think I have to check drone why this happens maybe mb4 on mysql)
wow - welcome to 2022 where emoji's still break things.
Drone seems to have flagged this PR as passed now, even though some of the suites fail for unrelated reasons.
Drone seems to have flagged this PR as passed now, even though some of the suites fail for unrelated reasons.
That's ok, all php8+ system tests are allowed to fail and 8.1 unit tests too, also postgres system tests
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:19 |
| Closed_By | ⇒ | PhilETaylor |
Strange but probably @HLeithner was doing, the Drone PHP 8.1 unit tests are being run by PHP 8.0 at the moment...
However, this new Unit test passes :)
