? Release Blocker ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
29 Dec 2021

Pull Request for Issue # and #36190 (comment) .

Summary of Changes

Fix the value of the checked_out column in the not yet released update SQL script from PR #36190 .

Rename the script so that it runs when updating from 4.1-beta1 to the future 4.1-beta2 which will contain the changes from PR #36190 .

With the name "4.1.0-2021-11-26.sql" it will not run because the schema version in database of a 4.1-beta1 is already "4.1.0-2021-11-28.sql".

@bembelimen You should have noticed that when merging.

Testing Instructions

  1. On a 4.1-dev or recent 4.1 nightly build which does not yet include the changes from PR #36190 , run the update SQL statement from that PR, i.e. for MySQL the one here: https://github.com/joomla/joomla-cms/blob/4.1-dev/administrator/components/com_admin/sql/updates/mysql/4.1.0-2021-11-26.sql (of course use the right table name prefix).
  2. Check in the system dashboard if there are checked out extensions, and in com_checkout for which table they are.
    Result: See section "Actual result BEFORE applying this Pull Request" below.
  3. Delete the record in database which you have added in step 1.
  4. Run the SQL statement from the modified update SQL of this PR here (of course use the right table name prefix), e.g. for MySQL:
INSERT INTO `#__extensions` (`name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES
('plg_system_jooa11y', 'plugin', 'jooa11y', 'system', 0, 1, 1, 0, 1, '', '', '', NULL, NULL, 0, 0);

Result: See section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

2021-12-29_checked-out-extension_1

2021-12-29_checked-out-extension_2

Expected result AFTER applying this Pull Request

2021-12-29_checked-out-extension_ok

Documentation Changes Required

None.

avatar richard67 richard67 - open - 29 Dec 2021
avatar richard67 richard67 - change - 29 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2021
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - change - 29 Dec 2021
Title
[4.1] Fix checked_out value in 4.1.0-2021-11-26.sql
[4.1] Fix checked_out value in 4.1.0-2021-11-26.sql and rename to 4.1.0-2021-12-29.sql
avatar richard67 richard67 - edited - 29 Dec 2021
avatar khu5h1 khu5h1 - test_item - 29 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 29 Dec 2021

I have tested this item successfully on c583b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

avatar alikon alikon - test_item - 29 Dec 2021 - Tested successfully
avatar alikon
alikon - comment - 29 Dec 2021

I have tested this item successfully on c583b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

avatar alikon alikon - change - 29 Dec 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 29 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

avatar brianteeman
brianteeman - comment - 29 Dec 2021

lgtm

avatar bembelimen bembelimen - change - 29 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-29 19:36:34
Closed_By bembelimen
Labels Added: ? Release Blocker ?
avatar bembelimen bembelimen - close - 29 Dec 2021
avatar bembelimen bembelimen - merge - 29 Dec 2021
avatar bembelimen
bembelimen - comment - 29 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment