? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
29 Dec 2021

https://php.watch/versions/8.1/serializable-deprecated

Summary of Changes

added magic method

Testing Instructions

php 8.1
on frontend do a search
check the log

Actual result BEFORE applying this Pull Request

PHP Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)

Expected result AFTER applying this Pull Request

no more deprecation

avatar alikon alikon - open - 29 Dec 2021
avatar alikon alikon - change - 29 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2021
Category Administration com_finder
avatar PhilETaylor
PhilETaylor - comment - 29 Dec 2021

Surely this is missing the actual implementation of the these functions?

avatar richard67
richard67 - comment - 29 Dec 2021

Surely this is missing the actual implementation of the these functions?

@PhilETaylor It should be enough if they call the serialize() and unserialize($serialized) methods defined a bit above, right? Or can they even be aliased somehow?

avatar PhilETaylor
PhilETaylor - comment - 29 Dec 2021

Replacement PR is here #36482 with unit tests that can be used to prove before PR (in PHP 7) and after PR (in PHP 8.1+)

avatar alikon
alikon - comment - 29 Dec 2021

closing in favour of #36482

avatar alikon alikon - close - 29 Dec 2021
avatar alikon alikon - change - 29 Dec 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-12-29 16:23:32
Closed_By alikon
Labels Added: ?

Add a Comment

Login with GitHub to post a comment