User tests: Successful: Unsuccessful:
The Pull Request started as simple "add php 8.1 and 8.2" to the test pipeline...
Now I try to full fill all requirements for phpunit 9.5...
TODOS:
Done:
Status | New | ⇒ | Pending |
Category | ⇒ | Unit Tests |
Labels |
Added:
?
?
|
phpunit is out of date - each is not available in php8
hmm looks like phpunit is broken on 8.0+?
No it seems the patch is not applied to the new image (but I thought phpunit 8 got updated to support 8.0) I will take a look
phpunit is out of date - each is not available in php8
No idea what you mean https://phpunit.de/supported-versions.html phpunit 8 shouldn't be the problem, for 3.10 we will likely stick to phpunit 4 and 8. Maybe someone want to look at https://github.com/Yoast/PHPUnit-Polyfills if it could solve some problems for us (didn't looked at it)
Cough #36393
It's not ignored, I just added the tests first so it's easier to check and complete everything at once, but Christmas time is family time and I have only limited timeslots beside work.
Thanks for reading the first line of my issue and nothing more. I’ll do the work myself as you seem to have no interest in understanding that pollyfilling is not the way forward for PHP 8 and PHPUnit 9
Did I said that? Problem is to have the same phpunit version for php 5.3 and 8.1, that's the reason why I see this as an option for J3 not for j4. But as already mentioned I didn't looked at it at all. Please stop telling me what I have done and what I didn't.
I only said I will look at this when the ci provides proper testing images, not more not less.
Thanks
Category | Unit Tests | ⇒ | Unit Tests Repository |
Title |
|
Im not sure what you have done to drone but every PR since yesterday is failing...
I will take a look, it's possible that it noe uses the development php.ini (before it's doesn't used any and had a memory limit of 128mb)
ok it wasn't the ini stuff, the git repository wasn't clean and mixed the php versions, new build is running and should fix the problem soon.
Category | Unit Tests Repository | ⇒ | Unit Tests Libraries Repository |
Category | Unit Tests Repository Libraries | ⇒ | Unit Tests Repository |
@HLeithner do you think that PR here is now good to go or do we need some updates here? Looks like the signature of the drone file is not correct as that build is blocked?
Thanks
Looks like the tests do not run in the first place? I do get Build is blocked, please, contact repo admin in order to proceed
https://ci.joomla.org/joomla/joomla-cms/53773
Because the drone file is not signed correctly
@HLeithner Are there any plans to complete this task here?
Will close here for now can be reopend when there are any plans to procced here and make it ready to be merged.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-21 17:05:54 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
Information Required
|
hmm looks like phpunit is broken on 8.0+?