Feeling Lucky
?
?
[#36461] - [4.1] Fix Task Scheduling Behavior with WebCron (...)
- Fixed in Code Base
- 31 Dec 2021
- Medium
- Build: 4.1-dev
- # 36461
- Diff
- ditsuke:fix-webcron-nodue-36460
User tests: Successful: Unsuccessful:
Pull Request for Issue #36460.
Summary of Changes
Fixes scheduling bypass with no ID passed to WebCron etc.
Testing Instructions
- Create a Scheduled task "WebCronTest" to Sleep for 5 seconds with:
- Execution Rule = Interval, Minutes
- Interval in Minutes = 60
- In the component options for Scheduler:
- Enable Web Cron
- Copy your secret URL. It should look like:
http://example.com/index.php/component/ajax/?plugin=RunSchedulerWebcron&group=system&format=json&hash=xxx - Visit URL. Takes 5 second => "WebCronTest" executed.
- Visit URL again/reload.
Actual result BEFORE applying this Pull Request
URL takes 5 seconds to load again => "WebCronTest" executed again even when it's not due.
Expected result AFTER applying this Pull Request
URL does not take 5 seconds. "WebCronTest" is not executed since it should not be due again before 60 minutes.
Documentation Changes Required
-
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
richard67
- comment
- 31 Dec 2021
@PhilETaylor Could you give it a quick test, too? For me it worked fine. Thanks in advance.
dgrammatiko
- comment
- 31 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36461.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 31 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36461.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-31 12:17:08 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 31 Dec 2021
Thx
I have tested this item✅ successfully on 82662d2
I've tested also with 10 minutes instead of 60 if the task is started again when this time has expired (I did not have the time to wait for an hour). This works, too.
I.e. without the PR: Task is triggered with every page load. With PR: Task is not triggered with every page load but is triggered when the last execution is 10 minutes or longer in past, as it should be.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36461.