When I press this button its not running a test - its actually running the actual task.. it should be renamed Run Task
Some scheduled tasks are not going to be scheduled, but manually run - by design - and the way to manually run these is to press the "Run" button... which at the moment says "Run Test" which is factually incorrect.
It should be renamed to "Run Task" and the column header changed too.
Labels |
Added:
No Code Attached Yet
|
Also if this is a "TEST" button then the next execution date should NOT change ... for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change, and should not be a month from the time I TEST the task..... it should be a month since the last time it was run by schedule.
Shall I work on this issue?
Shall I work on this issue?
Hi, sure go ahead and feel free to ask if you need any help :)
Shall I work on this issue?
Hi, sure go ahead and feel free to ask if you need any help :)
Hi, I am a first time contributer in joomla , How do I find where this code is ?
Shall I work on this issue?
Hi, sure go ahead and feel free to ask if you need any help :)
Hi, I am a first time contributer in joomla , How do I find where this code is ?
Welcome to the Joomla! community. Often the best way to find the relevant code is to find the component in question. For this issue, that component is com_scheduler
, which you can see in the "option" parameter of the URL for this view: http://yoursite.example/administrator/index.php?option=com_scheduler&view=tasks
. The other clues are the "view" parameter and the "administrator" in this URL.
You can find the relevant template file (relative to joomla root): administrator/components/com_scheduler/tmpl/tasks/default.php
. The View and Model for this page are in the com_scheduler/src
directory but you probably won't need them here.
Thanks for the information . Please review.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-08 17:42:02 |
Closed_By | ⇒ | richard67 |
Please reopen.
Three things are required here:
Status | Closed | ⇒ | New |
Closed_Date | 2022-01-08 17:42:02 | ⇒ | |
Closed_By | richard67 | ⇒ |
Reopening. Thanks for reporting.
Please review , I think only one issue part is yet to be solved i.e
Also if this is a "TEST" button then the next execution date should NOT change ... for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change, and should not be a month from the time I TEST the task..... it should be a month since the last time it was run by schedule.
Will you please let me know how to proceed to solve this issue as once the run task button is pressed it runs again from that point of time regardless of the scheduled date.
Please review , I think only one issue part is yet to be solved i.e Also if this is a "TEST" button then the next execution date should NOT change ... for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change, and should not be a month from the time I TEST the task..... it should be a month since the last time it was run by schedule.
Will you please let me know how to proceed to solve this issue as once the run task button is pressed it runs again from that point of time regardless of the scheduled date.
@niharikamahajan02 I believe we can leave the behavior as-is once it is renamed to just "Run task", however if the alternative behavior is needed it might require some changes in the Task driver class or just the place where $task->run() is being called. It should make for another PR however so you should limit the scope of #36725 to just the language. :)
for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change
This is absolutely needed! Any manual runs should have no effect on the scheduling of the next run. There are legitimate reasons for having the ability to be able to ad-hoc run a task.
For example, if a task is to run a backup, you might want to run several manual backups, not effecting the weekly schedule - just an example.
@PhilETaylor Could you check if PR #36725 and if yes, close the issue here, or if no report back there in the PR what's missing? The author of the PR is a new contributor so he might need some advise in case if something's missing. Thanks in advance.
for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change
This is absolutely needed! Any manual runs should have no effect on the scheduling of the next run. There are legitimate reasons for having the ability to be able to ad-hoc run a task.
For example, if a task is to run a backup, you might want to run several manual backups, not effecting the weekly schedule - just an example.
Absolutely, I can see the use case now! Once the current PR to rename it gets through I'll work on making this possible.
@PhilETaylor Could you check if PR #36725 and if yes, close the issue here, or if no report back there in the PR what's missing? The author of the PR is a new contributor so he might need some advise in case if something's missing. Thanks in advance.
Once the current PR to rename it gets through ...
@ditsuke You mean #36725 ? Or is there another one I am not aware of?
@richard67 the current PR does not take care of:
I believe these should be dealt with in a separate PR.
Edit: yep
For the permission thing ("Ensuring manual runs cannot be executed by public users.") I think there is issue #36677 and PR #36719 , or is that something else?
For the "Modifying manual runs so that they no longer affect the next planned execution of the task." it would need a new issue if we close this here.
For the permission thing ("Ensuring manual runs cannot be executed by public users.") I think there is issue #36677 and PR #36719 , or is that something else?
The issue/PR do not take care of public permissions yet, but I think we could include them since they're pretty close!
For the "Modifying manual runs so that they no longer affect the next planned execution of the task." it would need a new issue if we close this here.
Please review , I think only one issue part is yet to be solved i.e Also if this is a "TEST" button then the next execution date should NOT change ... for example, if I have a task that runs monthly, and half way through the month I click "Test Task" then the next execution date should NOT change, and should not be a month from the time I TEST the task..... it should be a month since the last time it was run by schedule.
Will you please let me know how to proceed to solve this issue as once the run task button is pressed it runs again from that point of time regardless of the scheduled date.@niharikamahajan02 I believe we can leave the behavior as-is once it is renamed to just "Run task", however if the alternative behavior is needed it might require some changes in the Task driver class or just the place where $task->run() is being called. It should make for another PR however so you should limit the scope of #36725 to just the language. :)
Ok sir!
Can I work on this issue,or it's already solved
I have already submitted a PR for this issue .But did not solve Ref: (#36453 (comment)) , so if you want you may resolve this (if no one is working on it). Thanks.
Also if I set the ACL Permission for "Test Task" to "allowed" for public... I can run the task without authentication... probably not what is wanted :)
@PhilETaylor sir, can we create the separate issue for this, because I have solved for the button and column header, so if you are fine with this, then I will open the PR , otherwise not thanks :)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:36:13 |
Closed_By | ⇒ | PhilETaylor |
Also if I set the ACL Permission for "Test Task" to "allowed" for public... I can run the task without authentication... probably not what is wanted :)