? Success

User tests: Successful: Unsuccessful:

avatar speedy111
speedy111
26 May 2014
avatar jurianeven jurianeven - open - 26 May 2014
avatar Bakual
Bakual - comment - 26 May 2014

Can you use spaces to align the doc blocs between the type, name and description? Currently you have spaces and tabs mixed.

avatar jurianeven
jurianeven - comment - 26 May 2014

Done, I've overwritten the commit with one with spaces.

avatar Bakual Bakual - change - 26 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-26 14:10:16
avatar Bakual Bakual - close - 26 May 2014
avatar Bakual Bakual - close - 26 May 2014
avatar Bakual
Bakual - comment - 26 May 2014

Thanks.
I just checked with phpcs and we don't align the @return and the @param section. I've fixed that already before merging so Jenkins will be pleased :smiley:

avatar jurianeven
jurianeven - comment - 26 May 2014

Ah, ok! Didn't know that. Thanks for merging/committing! :)

avatar jurianeven jurianeven - head_ref_deleted - 26 May 2014

Add a Comment

Login with GitHub to post a comment