[#36445] - [4] Au revoir JObject...
- Fixed in Code Base
- 30 Dec 2021
- Medium
- Build: 4.0-dev
- # 36445
- Diff
- PhilETaylor:byebye-jobject
User tests: Successful: Unsuccessful:
Manual replacement of all JObject to Joomla\CMS\Object\CMSObject references.
ONE THING THAT NEEDS REAL TESTING is this change https://github.com/joomla/joomla-cms/compare/4.0-dev...PhilETaylor:byebye-jobject?expand=1#diff-b31b65d1210170b779c0e6e9c198290ddd7ea0be9e1be88f0d2d06f26ff263e4R110
And YES I KNOW that Joomla\CMS\Object\CMSObject is already @deprecated but lets take it one step at a time...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_menus |
| Labels |
Added:
?
|
||
Yeah. I'm confident in the CMSObject::class change btw. We're doing it in various other places in core (e.g. https://github.com/joomla/joomla-cms/compare/4.0-dev...PhilETaylor:byebye-jobject?expand=1#diff-30fa9bc9ba82e382bf7ca46349946055a8f9f881d454dfd970971556828b7a6bR743)
| Category | Administration com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_menus | ⇒ | Administration com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_menus com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_workflow |
After a very a scary rebase my mistake where I thought I had lost everything, I thankfully had not, and have forced pushed the changes after manually merging them.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-30 22:53:20 |
| Closed_By | ⇒ | wilsonge |
Phew and thanks!
I will fix the conflicts asap - serves me right for trying to do too much too soon