? ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
27 Dec 2021

Pull Request for Issue #36437.

Summary of Changes

Pagination in the task manager was broken because we were filtering out orphaned tasks from an already paginated list. To solve this, we could either filter out orphans from a fully loaded task list or do the filtering within the query by passing all active routines queries through task plugins. I chose the latter approach, which should fix this issue.

Testing Instructions

  • Create > 5 tasks.
  • Orphan some of the tasks so that non-orphaned tasks = 5.
  • Set Task Manager pagination size to 5.
  • Exclude orphaned tasks in the task manager (the default is not really applied)

Actual result BEFORE applying this Pull Request

We see < 5 tasks in the task manager.

Expected result AFTER applying this Pull Request

We see 5 tasks in the task manager.

Documentation Changes Required

-

avatar ditsuke ditsuke - open - 27 Dec 2021
avatar ditsuke ditsuke - change - 27 Dec 2021
The description was changed
avatar ditsuke ditsuke - change - 27 Dec 2021
Title
Fix pagination in Task Scheduler
[4.1] Fix pagination in Task Scheduler
avatar ditsuke ditsuke - edited - 27 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2021
Category Administration
avatar bembelimen bembelimen - change - 31 Dec 2021
Labels Added: ?
avatar chmst
chmst - comment - 31 Dec 2021

I have tested this item successfully on 4fa2ace


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36438.

avatar chmst chmst - test_item - 31 Dec 2021 - Tested successfully
avatar richard67
richard67 - comment - 31 Dec 2021

I have tested this item successfully on 4fa2ace


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36438.

avatar richard67 richard67 - test_item - 31 Dec 2021 - Tested successfully
avatar richard67 richard67 - change - 31 Dec 2021
Status New Ready to Commit
avatar richard67
richard67 - comment - 31 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36438.

avatar richard67 richard67 - change - 31 Dec 2021
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 31 Dec 2021 - chmst: Tested successfully
avatar richard67 richard67 - alter_testresult - 31 Dec 2021 - richard67: Tested successfully
avatar bembelimen bembelimen - change - 31 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-31 13:05:54
Closed_By bembelimen
avatar bembelimen bembelimen - close - 31 Dec 2021
avatar bembelimen bembelimen - merge - 31 Dec 2021
avatar bembelimen
bembelimen - comment - 31 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment