? ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
27 Dec 2021

Pull Request for Issue #36435.

Summary of Changes

Excludes orphaned tasks from TaskModel::getTask()'s task locking query so don't end up acquiring locks/trying to run orphaned tasks.

Testing Instructions

  • Create task with a short interval based rule
  • Orphan the task by disabling the parent plugin.
  • Wait for the task to be triggered

Actual result BEFORE applying this Pull Request

The task is triggered, a "running" icon indicating a lock on the task is visible on visiting the Task Manager.

Expected result AFTER applying this Pull Request

The task is not triggered.

Documentation Changes Required

-

avatar ditsuke ditsuke - open - 27 Dec 2021
avatar ditsuke ditsuke - change - 27 Dec 2021
Title
Fix task queue behavior with orphaned tasks
[4.1] Fix task queue behavior with orphaned tasks
avatar richard67 richard67 - change - 31 Dec 2021
The description was changed
Labels Added: ?
avatar richard67 richard67 - edited - 31 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2021
Category Administration
avatar richard67
richard67 - comment - 31 Dec 2021

I have tested this item successfully on be01cf8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36436.

avatar richard67 richard67 - test_item - 31 Dec 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 3 Jan 2022

I have tested this item successfully on be01cf8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36436.

avatar jwaisner jwaisner - test_item - 3 Jan 2022 - Tested successfully
avatar jwaisner jwaisner - change - 3 Jan 2022
Status New Ready to Commit
avatar jwaisner
jwaisner - comment - 3 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36436.

avatar bembelimen bembelimen - change - 5 Jan 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 6 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-06 11:40:36
Closed_By bembelimen
avatar bembelimen bembelimen - close - 6 Jan 2022
avatar bembelimen bembelimen - merge - 6 Jan 2022
avatar bembelimen
bembelimen - comment - 6 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment