? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
27 Dec 2021

Code Review Removing Technical Debt.

Remove reference to old JPrefixed Class + other small cleanups of doc blocks.

Nothing here is controversial and should be a quick test and merge.

These changes are manually made and reviewed, over several hours, and are restricted to the /components/ folder only.

This PR is not exhaustive.

avatar PhilETaylor PhilETaylor - open - 27 Dec 2021
1dd6ea9 27 Dec 2021 avatar PhilETaylor cs
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2021
Category Front End com_config com_contact com_content com_contenthistory com_fields com_finder com_modules com_newsfeeds com_tags com_users
avatar wilsonge
wilsonge - comment - 30 Dec 2021

Shall we go with this one for conflict resolving next?

avatar PhilETaylor
PhilETaylor - comment - 30 Dec 2021

Hahahaha I suck obviously

avatar PhilETaylor PhilETaylor - change - 30 Dec 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 30 Dec 2021

Done.

6f6157b 30 Dec 2021 avatar PhilETaylor weird
ed60d82 30 Dec 2021 avatar PhilETaylor cs
avatar wilsonge
wilsonge - comment - 30 Dec 2021

Sorry one last rebase. I merged in the void return PR

avatar PhilETaylor
PhilETaylor - comment - 30 Dec 2021

ok I think Im finally done with this one

  1. Github lies...
  2. Github web interface sucks
  3. Caching on Github web pages sucks
  4. Nearly all the suggestions for Input you provided had tabs in them :)
  5. grrrrrr
avatar wilsonge
wilsonge - comment - 31 Dec 2021

Oops :( Sorry!

avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

Now drone cs is not happy - will fix in morning if you don’t as I’m in bed now

avatar wilsonge wilsonge - change - 31 Dec 2021
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-31 00:11:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Dec 2021
avatar wilsonge wilsonge - merge - 31 Dec 2021
avatar wilsonge
wilsonge - comment - 31 Dec 2021

Thanks!

avatar wilsonge
wilsonge - comment - 31 Dec 2021

I'll fix drone now - I trust myself more in IntelliJ than though the GitHub UI after this :D

Add a Comment

Login with GitHub to post a comment