? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Dec 2021

Code review.

Delete all the things. Make them smaller. Prettier. Modern. More Professional. Less Code = Less Bugs

  • 'return' is unnecessary as the last statement in a method
  • Ternary expression replaced with short version
  • Unnecessary 'return' statement
  • 'continue' is unnecessary as the last statement in a loop
avatar PhilETaylor PhilETaylor - open - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2021
Category Libraries Administration com_finder com_languages Front End com_content Libraries Plugins
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 25 Dec 2021
Title
[4] Delete lots of code ;-)
[4] Delete lots of code
avatar PhilETaylor PhilETaylor - edited - 25 Dec 2021
avatar Quy Quy - test_item - 27 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 27 Dec 2021

I have tested this item successfully on 7d30e21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36415.

avatar PhilETaylor
PhilETaylor - comment - 27 Dec 2021

Thanks for testing @Quy - appreciate it.

avatar RickR2H
RickR2H - comment - 16 Jan 2022

I have tested this item successfully on 7d30e21

Nice cleanup! thanks @PhilETaylor


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36415.

avatar RickR2H RickR2H - test_item - 16 Jan 2022 - Tested successfully
avatar RickR2H RickR2H - change - 16 Jan 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 16 Jan 2022

RTX


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36415.

avatar bembelimen bembelimen - change - 21 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-21 13:03:34
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 21 Jan 2022
avatar bembelimen bembelimen - merge - 21 Jan 2022
avatar bembelimen
bembelimen - comment - 21 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment