[#36411] - [4] Wrong string concatenation operator
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 36411
- Diff
- PhilETaylor:patch-325
User tests: Successful: Unsuccessful:
Code review.
This method is called by passing the size increase to it.
A size increase should be (and is) a number and not a string.
Therefore the docblock is incorrect which in turn makes the concatenation operator incorrect because if it WERE REALLY strings it would be .= and not +=.
More correctly, what this method is passed is integers, or even more correctly, integers or the result of strlen or the result of filesize, the latter of these can also return false which would be passed to this method.
PHP 7.2 (Joomla 4's low php limit) doesn't allow union types but it is common to document them commented out.
I have updated the docblock and now all static analysis is happy.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:12 |
| Closed_By | ⇒ | PhilETaylor |