? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Dec 2021

Summary of Changes

There is an edge case, where this method can be called with a set of ids, that gets pruned, leaving no ids to feature, which in turn rules a code path that leaves the redirect $message undefined.

Testing Instructions

Code review. Best viewed with no whitespace https://github.com/joomla/joomla-cms/pull/36404/files?diff=unified&w=1

Actual result BEFORE applying this Pull Request

$message is undefined.

Expected result AFTER applying this Pull Request

return early after identifying that we have no $ids to process.

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2021
Category Administration com_content
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar Quy Quy - test_item - 26 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 26 Dec 2021

I have tested this item successfully on ae6d1f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36404.

avatar wilsonge wilsonge - change - 29 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-29 23:11:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Dec 2021
avatar wilsonge wilsonge - merge - 29 Dec 2021
avatar wilsonge
wilsonge - comment - 29 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment