[#36400] - [3+] php8 deprecation str_replace Passing null to param
- Fixed in Code Base
- 5 Jan 2022
- Medium
- Build: 3.10-dev
- # 36400
- Diff
- PhilETaylor:patch-315
User tests: Successful: Unsuccessful:
Ensure that if there is no browserVersion then we do not run null through str_replace
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
you should never be trying to push NULL through str_replace regardless of where its run :)
just wondering if this has unmasked a rabbit hole
Welcome to the PHP 8.1+ party :)
got this deprecation notice as well on J.4 too
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36400.
got this deprecation notice as well on J.4 too
Where? This is the string used for the name of all the cookies. If it's not unique it starts to get concerning.
I only noticed it on phpunit runs.
| Labels |
Added:
?
?
|
||
build now passing.
I think the fix is valid, the issue may happen when WebClient::detectBrowser fail to detect the browser and so version.
Can happen due many reasons, as UserAgent string is not strict and can be anything.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36400.
Will merge this for now but I would say that complete method does not make sense to me but looks like I'm the only one here :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-05 19:37:13 |
| Closed_By | ⇒ | zero-24 |
Is this a 'real world' problem? Or something limited to PHPUnit runs - where we should just mock things better. Asking because if there's no version presumably there's no user agent either and we're just md5'ing the base url of the site here and not getting a unique hash ever (unsure what the implications are of that without starting to deep dive)
I mean I'm sure this solves the immediate problem - just wondering if this has unmasked a rabbit hole