? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Dec 2021

Summary of Changes

fix PHP 8 Deprecation preg_split, limit s/null/-1

https://www.php.net/preg_split

Testing Instructions

php 8.1 command line

libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Filter/OutputFilterTest.php

Actual result BEFORE applying this Pull Request

libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Filter/OutputFilterTest.php --debug


PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testLinkXHTMLSafe' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testLinkXHTMLSafe' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testStringJSSafe' started
PHP Deprecated:  preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Filter/OutputFilter.php on line 50
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testStringJSSafe' ended

Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Filter/OutputFilter.php on line 50
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testStringURLSafe' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testStringURLSafe' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testAmpReplace' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Filter\OutputFilterTest::testAmpReplace' ended


Time: 29 ms, Memory: 10.00 MB

OK (4 tests, 9 assertions)

Expected result AFTER applying this Pull Request

libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Filter/OutputFilterTest.php

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

....                                                                4 / 4 (100%)

Time: 34 ms, Memory: 10.00 MB

OK (4 tests, 9 assertions)

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 24 Dec 2021

added an additional change to this, but simple to see its right with code review.

avatar PhilETaylor PhilETaylor - change - 30 Dec 2021
Labels Added: ?
avatar zero-24
zero-24 - comment - 30 Dec 2021

Merged thabks @PhilETaylor

Add a Comment

Login with GitHub to post a comment