? J4 Issue ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Dec 2021

Code review

Screenshot 2021-12-24 at 17 49 56

  <b>Deprecated</b>:  Return type of Joomla\CMS\Document\JsonapiDocument::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in <b>/tests/www/postgres/libraries/src/Document/JsonapiDocument.php</b> on line <b>162</b><br />
39s
240	  <br />
avatar PhilETaylor PhilETaylor - open - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Title
[4.1] ReturnTypeWillChange
[4.1] PHP 8 ReturnTypeWillChange
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar PhilETaylor PhilETaylor - change - 24 Dec 2021
Title
[4.1] PHP 8 ReturnTypeWillChange
[4.1] PHP 8 ReturnTypeWillChange JsonapiDocument::jsonSerialize
avatar PhilETaylor PhilETaylor - edited - 24 Dec 2021
avatar alikon
alikon - comment - 29 Dec 2021

this should go in 4.0 imho

avatar alikon alikon - test_item - 29 Dec 2021 - Tested successfully
avatar alikon
alikon - comment - 29 Dec 2021

I have tested this item successfully on bd10738


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36394.

avatar Fedik Fedik - test_item - 29 Dec 2021 - Tested successfully
avatar Fedik
Fedik - comment - 29 Dec 2021

I have tested this item successfully on bd10738


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36394.

avatar Fedik Fedik - change - 29 Dec 2021
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 29 Dec 2021

R
T
C


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36394.

avatar Fedik
Fedik - comment - 29 Dec 2021

yeah, it better for 4.0

avatar PhilETaylor PhilETaylor - change - 29 Dec 2021
Labels Added: ? J4 Issue ?
avatar PhilETaylor
PhilETaylor - comment - 29 Dec 2021

Backported here #36476

avatar PhilETaylor PhilETaylor - close - 29 Dec 2021
avatar PhilETaylor PhilETaylor - change - 29 Dec 2021
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2021-12-29 13:17:52
Closed_By PhilETaylor
Labels Added: ?

Add a Comment

Login with GitHub to post a comment