? Success

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
24 May 2014

An updated PR for #1936, this is made against staging.

As for the en-GB.com_users.ini file, not sure what happened here, this whole PR was made in PhpStorm, go figure :)

This is for tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31952&start=0

avatar roland-d roland-d - open - 24 May 2014
avatar Bakual
Bakual - comment - 24 May 2014

Check your codestyle settings in PhpStorm. It added a space around the = which we don't want in the language files.

avatar roland-d
roland-d - comment - 24 May 2014

@Bakual Thanks for the sharp eye, I did not even notice. Codestyle setting was OK but in PhpStorm when I have the commit dialog it has an option called Reformat code, this was checked and caused PhpStorm to add the spaces to the file. All fixed now.

avatar brianteeman
brianteeman - comment - 25 May 2014

Great work just two small corrections needed

avatar roland-d roland-d - change - 25 May 2014
Labels Added: ?
Removed: ?
avatar roland-d roland-d - change - 25 May 2014
Title
[#31952 ] Various language string updates for users
[#31952] [#31952 ] Various language string updates for users
avatar roland-d roland-d - change - 25 May 2014
Title
[#31952 ] Various language string updates for users
[#31952] [#31952 ] Various language string updates for users
avatar roland-d
roland-d - comment - 25 May 2014

Thanks @brianteeman I have made the 2 corrections.

avatar brianteeman
brianteeman - comment - 25 May 2014

Awesome - thanks

avatar infograf768 infograf768 - close - 25 May 2014
avatar infograf768 infograf768 - change - 25 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-25 09:56:41
avatar infograf768 infograf768 - close - 25 May 2014
avatar roland-d roland-d - head_ref_deleted - 6 May 2015

Add a Comment

Login with GitHub to post a comment