Feeling Lucky
?
?
[#36386] - [4.0] Replace input with button
- Fixed in Code Base
- 29 Dec 2021
- Medium
- Build: 4.0-dev
- # 36386
- Diff
- C-Lodder:patch-4
User tests: Successful: Unsuccessful:
Summary of Changes
Use an actual button for the "login button", rather than an input.
Testing Instructions
Make sure you can still logout via mod_login
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
| Category | Modules Front End | ⇒ | Modules Front End Templates (site) |
C-Lodder
- comment
- 23 Dec 2021
@brianteeman Only found two other references to input type="submit" in the whole repo. Could you let me know where the third is, so I can change it?
brianteeman
- comment
- 23 Dec 2021
It was in a js script
C-Lodder
- comment
- 23 Dec 2021
Only one I can see is in core.js, but that's a hidden input.
brianteeman
- comment
- 23 Dec 2021
my bad - i missed that it was hidden
brianteeman
- comment
- 23 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36386.
Quy
- comment
- 26 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36386.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36386.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-29 01:39:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 29 Dec 2021
Thanks!
probably should be changed in the three other places as well